Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for isCustomChannel in GitHubProvider.ts #7665 #7666

Merged

Conversation

sethjray
Copy link
Contributor

This pull request implements the fix I suggested in #7665

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: 5234ce5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 5234ce5
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/64b1b0055f58ea0008127386
😎 Deploy Preview https://deploy-preview-7666--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

Hi @sethjray, thanks for contributing! Just to double-check, have you tested this locally? Such as via patch-package?

Wondering if this is also related #7669

@sethjray
Copy link
Contributor Author

Hi @mmaietta, yes I tested it locally by editing the package within the node_modules directory. It fixed the problem I was having, and began properly detecting when a branch did not have a prerelease tag associated with it.

And yes, I would imagine that #7669 is caused by the same thing. Their stable branch is being mislabeled as a custom branch (named "null" probably) and it isn't allowing their alpha version to upgrade to it.

Thanks for your help, and let me know if there's anything else I can do!

@mmaietta mmaietta merged commit 441da40 into electron-userland:master Jul 20, 2023
13 checks passed
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants