fix: execute %SYSTEMROOT% cmd.exe directly during NSIS installer #8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a9ca77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Feb 20, 2024
Merged
|
SO what's the difference between It seems
|
|
In powershell you can check env vars via |
Crujera27
added a commit
to VI-Software/vis-launcher
that referenced
this pull request
Mar 5, 2024
Solo para Windows: el instalador de NSIS realiza una llamada al sistema para abrir cmd.exe a través de NSExec en el script del instalador .nsh. NSExec busca de forma predeterminada el directorio actual donde se encuentra el instalador antes de buscar PATH. Esto significa que si un atacante puede colocar un archivo ejecutable malicioso llamado cmd.exe en la misma carpeta que el instalador, el instalador ejecutará el archivo malicioso. Parches Corregido en electron-userland/electron-builder#8059 Soluciones alternativas Ninguno, se ejecuta en el nivel del instalador antes de que la aplicación esté presente en el sistema, por lo que no hay forma de verificar si existe en un instalador actual. Referencias https://cwe.mitre.org/data/definitions/426.html https://cwe.mitre.org/data/definitions/427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHSA-r4pf-3v7r-hh55