Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependencies): remove UUID dependency for Electron >=8.0.0-beta.1 #45

Merged
merged 2 commits into from
Dec 13, 2019
Merged

fix(dependencies): remove UUID dependency for Electron >=8.0.0-beta.1 #45

merged 2 commits into from
Dec 13, 2019

Conversation

fcastilloec
Copy link
Collaborator

@fcastilloec fcastilloec commented Oct 26, 2019 •
edited

We will also have to upgrade -debian and -redhat to use this.

@codecov
Copy link

codecov bot commented Oct 26, 2019 •
edited

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         198    198           
=====================================
  Hits          198    198
Impacted Files Coverage Δ
src/dependencies.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fc13c...6cdad4e. Read the comment docs.

malept
malept approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a minor test description change.

test/dependencies.js Outdated Show resolved Hide resolved
@malept malept changed the title feat: remove UUID dependency for Electron >=8.0.0-beta.1 fix: remove UUID dependency for Electron >=8.0.0-beta.1 Dec 13, 2019
@malept malept changed the title fix: remove UUID dependency for Electron >=8.0.0-beta.1 fix(dependencies): remove UUID dependency for Electron >=8.0.0-beta.1 Dec 13, 2019
@malept malept merged commit cf3cd9a into master Dec 13, 2019
@malept malept deleted the electron-8 branch December 13, 2019 18:22
@malept malept mentioned this pull request Jan 22, 2020
Merged
malept pushed a commit to electron-userland/electron-installer-redhat that referenced this pull request Jan 22, 2020
@fcastilloec @malept
chore: update dependencies (#151)
9f8ccab 
Adds support for Electron 8 compatible dependencies (electron-userland/electron-installer-common#45)

BREAKING CHANGE: drops support for Node < 10
This was referenced Jan 22, 2020
Merged
Merged
This was referenced Jan 22, 2020
Merged
Merged
Merged
This was referenced Jan 31, 2020
Merged
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcastilloec @malept