Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set permissions for suid sandbox helper #184

Merged
merged 8 commits into from
May 2, 2019
Merged

feat: set permissions for suid sandbox helper #184

merged 8 commits into from
May 2, 2019
+2 −1

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Mar 7, 2019

No description provided.

MarshallOfSound
MarshallOfSound reviewed Mar 7, 2019
View reviewed changes
src/installer.js Outdated Show resolved Hide resolved
@nornagon nornagon marked this pull request as ready for review March 7, 2019 22:47
@nornagon
Copy link
Contributor Author

nornagon commented Mar 7, 2019

@MarshallOfSound can you confirm that stagingDir is the right path to use (c.f. stagingAppDir)? I haven't tested this locally :|

@nornagon nornagon mentioned this pull request Mar 7, 2019
Merged
6 tasks
malept
malept previously requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@malept malept left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use async/await yet here, we target plain Node 6 for another 1.5 months 😞

src/installer.js Outdated Show resolved Hide resolved
src/installer.js Outdated Show resolved Hide resolved
@malept malept mentioned this pull request Mar 8, 2019
Merged
@malept malept dismissed their stale review March 8, 2019 07:29

I made changes to the PR

@nornagon nornagon mentioned this pull request Apr 25, 2019
Closed
3 tasks
@malept
Copy link
Member

malept commented May 2, 2019

Sorry, I completely forgot about this PR 😢

@malept malept merged commit 7297df6 into electron-userland:master May 2, 2019
@PalmerAL PalmerAL mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept left review comments

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @malept @MarshallOfSound