-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable setuid sandbox on linux #17269
Conversation
This is a draft PR because it doesn't yet address the distribution side of this change. Specifically, in order to work correctly, the
If the above conditions are not met, the sandbox will not function. Chrome solves this problem during installation: the |
30d8ea4
to
e543277
Compare
Requesting review from @electron/wg-security and @zcbenz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to support renaming of this binary to something static like electron_sandbox
or even dynamic and based on the current binaries name?
E.g. myapp_sandbox
Not a deal breaker and this is literally just aesthetics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on build config changes.
Its hardcoded in upstream |
it would be relatively easy but questionably valuable to rename the binary to something like |
If it requires a patch to make it |
Release Notes Persisted
|
Can we get this backported to 5-0-x? |
/trop run backport-to 5-0-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "5-0-x", please check out #17343 |
Description of Change
This change enables the setuid sandbox on Linux. This allows Electron to run sandboxed in environments that disable CLONE_NEWUSER for unprivileged users (e.g. docker without
CAP_SYS_ADMIN
, and Arch Linux).Closes #16631.
Checklist
npm test
passesRelease Notes
Notes: Enabled the setuid sandbox on Linux, allowing Electron to launch sandboxed processes in environments that disable CLONE_NEWUSER for unprivileged users.