Always add revision/release to the RPM filename (#114)

* Use the Release (revision) number on the filename * Fix tests to account to Release(revision)
electron-userland · May 24, 2019 · dc75e94 · dc75e94
1 parent e0da5af
commit dc75e94
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/installer.js b/src/installer.js
@@ -15,7 +15,7 @@ const util = require('./util')
 const defaultLogger = debug('electron-installer-redhat')
 
 const defaultRename = function (dest, src) {
-  return path.join(dest, '<%= name %>-<%= version %>.<%= arch %>.rpm')
+  return path.join(dest, '<%= name %>-<%= version %>-<%= revision %>.<%= arch %>.rpm')
 }
 
 class RedhatInstaller extends common.ElectronInstaller {

diff --git a/test/cli.js b/test/cli.js
@@ -29,7 +29,7 @@ describe('cli', function () {
 
     runCLI({ src: 'test/fixtures/app-with-asar/', dest: outputDir, arch: 'x86' })
 
-    it('generates a `.rpm` package', () => access(path.join(outputDir, 'footest-0.0.1.x86.rpm')))
+    it('generates a `.rpm` package', () => access(path.join(outputDir, 'footest-0.0.1-1.x86.rpm')))
 
     cleanupOutputDir(outputDir)
   })
@@ -39,7 +39,7 @@ describe('cli', function () {
 
     runCLI({ src: 'test/fixtures/app-without-asar/', dest: outputDir, arch: 'x86_64' })
 
-    it('generates a `.rpm` package', () => access(path.join(outputDir, 'bartest-0.0.1.x86_64.rpm')))
+    it('generates a `.rpm` package', () => access(path.join(outputDir, 'bartest-0.0.1-1.x86_64.rpm')))
 
     after(() => fs.remove(outputDir))
   })