Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron 4 support #8

Merged
merged 3 commits into from
Dec 26, 2018
Merged

Add Electron 4 support #8

merged 3 commits into from
Dec 26, 2018

Conversation

malept
Copy link
Member

@malept malept commented Dec 26, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Move dependency management and reading the Electron version functionality to electron-installer-common. This gives us proper support for Electron 4.

@malept malept changed the title Use electron-installer-common Add Electron 4 support Dec 26, 2018
@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         242    242           
=====================================
  Hits          242    242
Impacted Files Coverage Δ
src/yaml.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f179adb...d8ee730. Read the comment docs.

@malept malept merged commit d53ca26 into master Dec 26, 2018
@malept malept deleted the electron-installer-common branch December 26, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant