New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle ID for Helper EH and Helper NP #261
Comments
Would #253 solve this problem? |
The extra info would probably work but really the packager already has the information it needs and is already renaming the helper files. So it seems like the default would be to put those values into the plist files. As is, the plist files are technically invalid, though it only comes into play when you try to submit to the app store. |
Evidently the author of #223 noticed this bug and is going to fix it. |
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to electron/packager#261 - Moved: `codesign` now with external `electron-osx-sign` module
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to maxogden#261 - Moved: `codesign` now with external `electron-osx-sign` module
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to maxogden#261 - Moved: `codesign` now with external `electron-osx-sign` module
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to maxogden#261 - Moved: `codesign` now with external `electron-osx-sign` module
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to maxogden#261 - Moved: `codesign` now with external `electron-osx-sign` module
- Added: platform `mas` for Mac App Store distribution - Added: CFBundleIdentifier is now filtered, according to Apple Documentation - Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to maxogden#261 - Moved: `codesign` now with external `electron-osx-sign` module
Fix: ix electron/packager#261 Fix: electron/packager#163 Added filterCFBundleIdentifier function Properties to set in app plist - CFBundleDisplayName - CFBundleIdentifier - CFBundleName Properties to set in helper plist - CFBundleDisplayName - CFBundleIdentifier - CFBundleName - CFBundleExecutable In testing script: - Added testing with special characters
Fixed in #223. |
The helper-bundle-id argument correctly sets the bundle id for the Helper app in it's plist file. However the Helper EH and Helper NP still have the original electron bundle ID.
The text was updated successfully, but these errors were encountered: