Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Commandeer #1137

Merged
merged 8 commits into from
Oct 24, 2019
Merged

feat: Added Commandeer #1137

merged 8 commits into from
Oct 24, 2019

Conversation

fsproru
Copy link
Contributor

@fsproru fsproru commented Jul 14, 2019

It's an honor to submit Commandeer to Electron Apps 🙌

Commandeer is a desktop app built by developers for developers. With Commandeer, you can take control of your cloud by managing your AWS resources in a nice, intuitive, and efficient desktop application.

Commandeer Website

Install it to your laptop
Install it to your laptop

Dashboard, see all your services in a central place
Dashboard, see all your services in a central place

Finally control Localstack
Finally control Localstack

Instantly switch between AWS accounts
Instantly switch between AWS accounts

Know where your resources are with Region Scanner
Know where your resources are with Region Scanner

Finally control Localstack
Finally control Localstack

Let me know if you have any questions. Looking forward to having the app accepted.

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this app is closed source. As per the submission guidelines, could you provide some evidence that this is an Electron app? Previous PRs are a good source for what other apps have used as evidence. Thanks!

@fsproru
Copy link
Contributor Author

fsproru commented Jul 18, 2019

Hi @ckerr, here you go. Let me know if you need anything else and thanks for working on such a great project!

Screen Shot 2019-07-17 at 11 54 00 PM

Screen Shot 2019-07-17 at 11 54 32 PM

@fsproru
Copy link
Contributor Author

fsproru commented Sep 4, 2019

Hi @ckerr, just wanted to follow up on adding Commandeer to Electron Apps. I updated it with the recent code from master. Let me know if you need anything else.

@vhashimotoo vhashimotoo changed the title Added Commandeer feat: Added Commandeer Sep 20, 2019
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🆒

@fsproru
Copy link
Contributor Author

fsproru commented Sep 27, 2019

Thanks @HashimotoYT, is there anything else that needs to be done to get it merged and published?

Copy link
Contributor

@Sanjit1 Sanjit1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think you will need to do anything more for the pull request to be merged. @ckerr @HashimotoYT it should be ready to merge

@vhashimotoo vhashimotoo merged commit 08647bc into electron:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants