Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new app name marssnow #1180

Closed
wants to merge 12 commits into from
Closed

new app name marssnow #1180

wants to merge 12 commits into from

Conversation

EGsnn
Copy link

@EGsnn EGsnn commented Sep 6, 2019

No description provided.

vhashimotoo
vhashimotoo reviewed Sep 20, 2019
View reviewed changes
apps/marssnow.yml Outdated
@@ -0,0 +1,21 @@
name: Marssnow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file, apps related stuff should be in the app folder not in the root.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm soo sorry ,it's delete

Sanjit1
Sanjit1 reviewed Sep 28, 2019
View reviewed changes
apps/marssnow/marssnow.yml Outdated
@@ -0,0 +1,21 @@
name: Marssnow
description: 'Desktop fast blogs app(博客2.0-快速博客)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End the description in a full stop

Sanjit1
Sanjit1 suggested changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@Sanjit1 Sanjit1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the error mentioned by @HashimotoYT and then rename the pull request to feat: Add Marssnow and then I think you should be good to go

vhashimotoo
vhashimotoo reviewed Oct 3, 2019
View reviewed changes
apps/marssnow/marssnow.yml Outdated
@@ -0,0 +1,21 @@
name: Marssnow
description: 'Desktop fast blogs app(博客2.0-快速博客)'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Desktop fast blogs app(博客2.0-快速博客)'.
description: 'Desktop fast blogs app(博客2.0-快速博客).'

Sanjit1
Sanjit1 suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@Sanjit1 Sanjit1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the requested changes, and then your app should pass the tests.
Also, rename the pull request to feat added Marssnow, to pass the semantic pull request test

best-regards

apps/marssnow/marssnow.yml Outdated
@@ -0,0 +1,19 @@
name: Marssnow
description: 'Desktop fast blogs app(博客2.0-快速博客).'
website: 'http://www.marssnow.com'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the http to https. I'm assuming for security purposes, Electron does not allow HTTP links on their websites.

best-regards

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for u and HashimotoYT help me 💙

vhashimotoo
vhashimotoo approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the app 💙

vhashimotoo
vhashimotoo suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this app is closed source. As per the submission guidelines, could you provide some evidence that this is an Electron app? Previous PRs are a good source for what other apps have used as evidence. Thanks!

@vhashimotoo
Copy link
Contributor

Thanks for your interesting of adding your application into the repository, unfortunately, you don't provide required information/changes in a required time, and we need to close this PR. If you still want in adding your application please open new PR with the required information/changes.

@vhashimotoo vhashimotoo closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhashimotoo vhashimotoo vhashimotoo requested changes

@Sanjit1 Sanjit1 Sanjit1 requested changes

Assignees
No one assigned
Labels
app: blocked/need-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EGsnn @vhashimotoo @Sanjit1