-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added OhHai Browser #1195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucasReade Please fix CI errors:
description
should end with a period / full stop:
AssertionError: Description should end in a period / full stop: 'A web browser build around differnt types of tabs': expected 's' to equal '.'
+ expected - actual
-s
+.
at Context.it (test/human-data.js:69:70)
2) human-submitted app data
ohhai-browser
ohhai-browser.yml
description
should not start description with "A" or "An":
AssertionError: Description should not start with 'A' or 'An': 'A web browser build around differnt types of tabs': expected [ 'a', 'an' ] to not include 'a'
at Context.it (test/human-data.js:80:40)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI error:
1) human-submitted app data
ohhai-browser
ohhai-browser.yml
description
should not start description with "A" or "An":
AssertionError: Description should not start with 'A' or 'An': 'A web browser build around differnt types of tabs.': expected [ 'a', 'an' ] to not include 'a'
at Context.it (test/human-data.js:80:40)
rewrite the description to not start with a or an
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then all you need is to wait for the build to pass
apps/ohhai-browser/ohhai-browser.yml
Outdated
@@ -0,0 +1,7 @@ | |||
name: 'OhHai Browser' | |||
description: 'A web browser build around differnt types of tabs.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you change line 2 from
description: 'A web browser build around different types of tabs.'
to
description: 'Web browser build around different types of tabs.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just fixed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kool so now Build works, but im not sure when the pull request will be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the app 💛
Web URL: https://ohhaibrowser.com/
Repo: https://github.com/OhHaiBrowser/Browser