fix: JSON schema Chromium compatibility (#479)

electron · Apr 14, 2023 · 2092eca · 2092eca
1 parent c1a6a2e
commit 2092eca
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/evm-config.schema.json b/evm-config.schema.json
@@ -16,7 +16,8 @@
         "electron",
         "electron:dist",
         "mksnapshot",
-        "node:headers"
+        "node:headers",
+        "chrome"
       ]
     },
     "extends": {
@@ -143,6 +144,19 @@
         "extends"
       ]
     },
+    {
+      "properties": {
+        "defaultTarget": {
+          "type": "string",
+          "pattern": "chrome"
+        }
+      },
+      "required": [
+        "defaultTarget",
+        "env",
+        "root"
+      ]
+    },
     {
       "required": [
         "root",

diff --git a/example-configs/evm.base.yml b/example-configs/evm.base.yml
@@ -13,3 +13,4 @@ gen:
 env:
   GIT_CACHE_PATH: /Users/user_name/.git_cache
   CHROMIUM_BUILDTOOLS_PATH: /path/to/your/developer/folder/src/build-tools
+$schema: file:///Users/user_name/.electron_build_tools/evm-config.schema.json
diff --git a/example-configs/evm.chromium.yml b/example-configs/evm.chromium.yml
@@ -0,0 +1,12 @@
+root: /path/to/chromium/
+defaultTarget: chrome
+gen:
+  args:
+    # path to goma for faster builds (https://notgoma.com)
+    - import("/Users/user_name/.electron_build_tools/third_party/goma.gn")
+    - is_debug = false
+  out: Default
+env:
+  GIT_CACHE_PATH: /Users/user_name/.git_cache
+  CHROMIUM_BUILDTOOLS_PATH: /path/to/your/developer/folder/src/build-tools
+$schema: file:///Users/user_name/.electron_build_tools/evm-config.schema.json