fix: JSON schema Chromium compatibility #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
reviewed
Apr 12, 2023
codebytere
force-pushed
the
fix-for-chromium
branch
from
9088477
to
5688a2d
Compare
codebytere
force-pushed
the
fix-for-chromium
branch
3 times, most recently
from
c9fa4c1
to
8fc9a67
Compare
dsanders11
reviewed
Apr 13, 2023
dsanders11
reviewed
Apr 13, 2023
codebytere
force-pushed
the
fix-for-chromium
branch
from
8fc9a67
to
0908fde
Compare
dsanders11
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON Schema added in #421 doesn't take into account a user looking to build Chromium itself.
This fixes that by adding an exception for the required schema objects if the
defaultTargetischrome.