fix: install npm_config_platform=win32 #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
Summary
This PR fixes an issue when trying to install
electron
on a linux machine with environment variablenpm_config_platform=win32
.Motivation
There is support for building electron apps on linux for windows. The
npm_config_platform
is an environment variable that is usually used to instruct npm packages about the platform for which custom or pre-built binaries should be downloaded.For example, running:
npm_config_platform=win32 npm i electron-chromedriver
should download the Windows chromedriver.exe even when I run it on a linux machine. This is currently broken and attempting to run it on linux fails with an error.There is not much use in downloading the Windows chromedriver on linux. However, if you have a native dependency like
sharp
and try to install all packages withnpm_config_platform=win32 npm i
in order to create a Windows build, you still get the same error fromelectron-chromedriver
package.