Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process field not read correctly #14

Closed
tong opened this issue Nov 28, 2019 · 2 comments
Closed

process field not read correctly #14

tong opened this issue Nov 28, 2019 · 2 comments

Comments

@tong
Copy link
Contributor

tong commented Nov 28, 2019

process fields are not read correctly, currently always true.

docs-parser/src/DocsParser.ts

Lines 164 to 168 in d4d62e1

// FIXME: We should read the process correctly
process: {
main: true,
renderer: true,
},

@tong tong mentioned this issue Nov 28, 2019
Closed
tong added a commit to tong/docs-parser that referenced this issue Dec 1, 2019
@tong
read process fields (electron#14)
780165c
MarshallOfSound pushed a commit that referenced this issue Dec 1, 2019
@tong @MarshallOfSound
feat: read process fields (#14) (#17)
d2e86df 
* read process fields (#14)

* improve reading process fields

* improve read process fields.

* add ProcessBlock type
* add markdown-helper.findProcess
* add markdown-helper.findProcess tests
@MarshallOfSound
Copy link
Member

Fixed in #17

@tong
Copy link
Contributor Author

tong commented Feb 15, 2020

Wondering why this still isn't used in electron releases ? @MarshallOfSound

@tong tong mentioned this issue Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tong @MarshallOfSound