[Bug]: webContents.send() does not thrown a serialization error #6822
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: Issue Labeled | |
on: | |
issues: | |
types: [labeled] | |
permissions: # added using https://github.com/step-security/secure-workflows | |
contents: read | |
jobs: | |
issue-labeled-with-status: | |
name: status/{confirmed,reviewed} label added | |
if: github.event.label.name == 'status/confirmed' || github.event.label.name == 'status/reviewed' | |
runs-on: ubuntu-latest | |
steps: | |
- name: Generate GitHub App token | |
uses: electron/github-app-auth-action@384fd19694fe7b6dcc9a684746c6976ad78228ae # v1.1.1 | |
id: generate-token | |
with: | |
creds: ${{ secrets.ISSUE_TRIAGE_GH_APP_CREDS }} | |
org: electron | |
- name: Set status | |
uses: dsanders11/project-actions/edit-item@eb760c48894b5702398529cbb8f6e98378e315d0 # v1.3.0 | |
with: | |
token: ${{ steps.generate-token.outputs.token }} | |
project-number: 90 | |
field: Status | |
field-value: ✅ Triaged | |
issue-labeled-blocked: | |
name: blocked/* label added | |
if: startsWith(github.event.label.name, 'blocked/') | |
runs-on: ubuntu-latest | |
steps: | |
- name: Generate GitHub App token | |
uses: electron/github-app-auth-action@384fd19694fe7b6dcc9a684746c6976ad78228ae # v1.1.1 | |
id: generate-token | |
with: | |
creds: ${{ secrets.ISSUE_TRIAGE_GH_APP_CREDS }} | |
org: electron | |
- name: Set status | |
uses: dsanders11/project-actions/edit-item@eb760c48894b5702398529cbb8f6e98378e315d0 # v1.3.0 | |
with: | |
token: ${{ steps.generate-token.outputs.token }} | |
project-number: 90 | |
field: Status | |
field-value: 🛑 Blocked | |
issue-labeled-blocked-need-repro: | |
name: blocked/need-repro label added | |
if: github.event.label.name == 'blocked/need-repro' | |
permissions: | |
issues: write # for actions-cool/issues-helper to update issues | |
runs-on: ubuntu-latest | |
steps: | |
- name: Check if comment needed | |
id: check-for-comment | |
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
GH_REPO: electron/electron | |
run: | | |
set -eo pipefail | |
COMMENT_COUNT=$(gh issue view ${{ github.event.issue.number }} --comments --json comments | jq '[ .comments[] | select(.author.login == "electron-issue-triage" or .authorAssociation == "OWNER" or .authorAssociation == "MEMBER") | select(.body | startswith("<!-- blocked/need-repro -->")) ] | length') | |
if [[ $COMMENT_COUNT -eq 0 ]]; then | |
echo "SHOULD_COMMENT=1" >> "$GITHUB_OUTPUT" | |
fi | |
- name: Generate GitHub App token | |
if: ${{ steps.check-for-comment.outputs.SHOULD_COMMENT }} | |
uses: electron/github-app-auth-action@384fd19694fe7b6dcc9a684746c6976ad78228ae # v1.1.1 | |
id: generate-token | |
with: | |
creds: ${{ secrets.ISSUE_TRIAGE_GH_APP_CREDS }} | |
- name: Create comment | |
if: ${{ steps.check-for-comment.outputs.SHOULD_COMMENT }} | |
uses: actions-cool/issues-helper@a610082f8ac0cf03e357eb8dd0d5e2ba075e017e # v3.6.0 | |
with: | |
actions: 'create-comment' | |
token: ${{ steps.generate-token.outputs.token }} | |
body: | | |
<!-- blocked/need-repro --> | |
Hello @${{ github.event.issue.user.login }}. Thanks for reporting this and helping to make Electron better! | |
Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, [Electron Fiddle](https://www.electronjs.org/fiddle) is a great tool for making small test cases and makes it easy to publish your test case to a [gist](https://gist.github.com) that Electron maintainers can use. | |
Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests. | |
Now adding the https://github.com/electron/electron/labels/blocked%2Fneed-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed. |