-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #71 from atom/78-chars-or-death
Indent all the files to 78-characters so that doc diffs are usable
- Loading branch information
Showing
18 changed files
with
307 additions
and
118 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,37 @@ | ||
Since atom-shell is using a different V8 version from the official node, you need to build native module against atom-shell's headers to use them. | ||
Since atom-shell is using a different V8 version from the official node, you | ||
need to build native module against atom-shell's headers to use them. | ||
|
||
You need to use node-gyp to compile native modules, you can install node-gyp via npm if you hadn't: | ||
You need to use node-gyp to compile native modules, you can install node-gyp | ||
via npm if you hadn't: | ||
|
||
```bash | ||
$ npm install -g node-gyp | ||
``` | ||
|
||
First you need to check which node release atom-shell is carrying via `process.version` (at the time of writing it is v0.10.5), then you can configure and build native modules via following commands: | ||
First you need to check which node release atom-shell is carrying via | ||
`process.version` (at the time of writing it is v0.10.5), then you can | ||
configure and build native modules via following commands: | ||
|
||
```bash | ||
$ cd /path-to-module/ | ||
$ HOME=~/.atom-shell-gyp node-gyp rebuild --target=0.10.5 --arch=ia32 --dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist | ||
``` | ||
|
||
The `HOME=~/.atom-shell-gyp` changes where to find development headers. The `--target=0.10.5` is specifying node's version. The `--dist-url=...` specifies where to download the headers. | ||
The `HOME=~/.atom-shell-gyp` changes where to find development headers. The | ||
`--target=0.10.5` is specifying node's version. The `--dist-url=...` specifies | ||
where to download the headers. | ||
|
||
## Use npm to build native modules | ||
|
||
Under most circumstances you would want to use npm to install modules, if you're using npm >= v1.2.19 (because [a patch](https://github.com/TooTallNate/node-gyp/commit/afbcdea1ffd25c02bc88d119b10337852c44d400) is needed to make `npm_config_disturl` work) you can use following code to download and build native modules against atom-shell's headers: | ||
Under most circumstances you would want to use npm to install modules, if | ||
you're using npm >= v1.2.19 (because [a | ||
patch](https://github.com/TooTallNate/node-gyp/commit/afbcdea1ffd25c02bc88d119b10337852c44d400) | ||
is needed to make `npm_config_disturl` work) you can use following code to | ||
download and build native modules against atom-shell's headers: | ||
|
||
```bash | ||
export npm_config_disturl=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist | ||
export npm_config_target=0.10.5 | ||
export npm_config_arch=ia32 | ||
HOME=~/.atom-shell-gyp npm install module-name | ||
``` | ||
``` |
Oops, something went wrong.