Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent all the files to 78-characters so that doc diffs are usable #71

Merged
merged 1 commit into from
Aug 29, 2013

Conversation

anaisbetts
Copy link
Contributor

If paragraphs aren't wrapped, it's really hard to see how they change. Let's keep them wrapped at 78 characters, so that our console-based Email program that we're not using can handle them

@anaisbetts
Copy link
Contributor Author

@zcbenz @atom/core any objections?

@probablycorey
Copy link

I feel like this makes editing more difficult. Instead of focusing on all
my attention on editing markdown, I'd have to spend some of that time
reformatting text. It breaks my writing flow.

From the command line the diffs look good with git diff and amazeballs
with git diff --word-diff. I feel like this is more of a .com issue, I'd
expect the emailed diffs to be in the same format as the diffs generated
from the command line.

On Thu, Aug 29, 2013 at 7:41 AM, Paul Betts notifications@github.comwrote:

@zcbenz https://github.com/zcbenz @atom/core any objections?


Reply to this email directly or view it on GitHubhttps://github.com//pull/71#issuecomment-23494481
.

@probablycorey
Copy link

I should note, I don't have a strong opinion about this (I could go either way). I just thought the downsides should be considered.

@kevinsawicki
Copy link
Contributor

I'm a strong to very strong 👍 on this, we wrap code, why not docs?

@anaisbetts
Copy link
Contributor Author

@probablycorey Get on this AutoFlow: Reflow Paragraph action my friend.

@probablycorey
Copy link

The readability goals for code and prose are different. Soft wrapped prose looks great, manually wrapped prose looks identical to soft wrapped prose.

Wrapped code looks terrible, this is why we try to keep lines below 80 chars. When a line gets too long we don't simulate what soft wrap would do, we refactor the line to get it below 80 chars.

I think the only valid argument for wrapping prose is because it makes the emailed diffs easier to read.

But again, because of AutoFlow: Reflow Paragraph I don't really feel that strongly about.

@kevinsawicki
Copy link
Contributor

Assuming every place prose is viewed has soft wrap available is the problem.

@probablycorey
Copy link

@xpaulbettsx: I was wrong about unwrapped prose diffs looking good on the command line (I was using a wrapped line as an example.) So 👍

@anaisbetts
Copy link
Contributor Author

Cool, finna hit the button

anaisbetts pushed a commit that referenced this pull request Aug 29, 2013
Indent all the files to 78-characters so that doc diffs are usable
@anaisbetts anaisbetts merged commit 132eb09 into master Aug 29, 2013
kevinsawicki pushed a commit that referenced this pull request May 9, 2017
Add delegate class for URLRequestContextGetter
kevinsawicki pushed a commit that referenced this pull request May 9, 2017
Add delegate class for URLRequestContextGetter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants