-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indent all the files to 78-characters so that doc diffs are usable #71
Conversation
@zcbenz @atom/core any objections? |
I feel like this makes editing more difficult. Instead of focusing on all From the command line the diffs look good with On Thu, Aug 29, 2013 at 7:41 AM, Paul Betts notifications@github.comwrote:
|
I should note, I don't have a strong opinion about this (I could go either way). I just thought the downsides should be considered. |
I'm a strong to very strong 👍 on this, we wrap code, why not docs? |
@probablycorey Get on this |
The readability goals for code and prose are different. Soft wrapped prose looks great, manually wrapped prose looks identical to soft wrapped prose. Wrapped code looks terrible, this is why we try to keep lines below 80 chars. When a line gets too long we don't simulate what soft wrap would do, we refactor the line to get it below 80 chars. I think the only valid argument for wrapping prose is because it makes the emailed diffs easier to read. But again, because of |
Assuming every place prose is viewed has soft wrap available is the problem. |
@xpaulbettsx: I was wrong about unwrapped prose diffs looking good on the command line (I was using a wrapped line as an example.) So 👍 |
Cool, finna hit the button |
Indent all the files to 78-characters so that doc diffs are usable
Add delegate class for URLRequestContextGetter
Add delegate class for URLRequestContextGetter
If paragraphs aren't wrapped, it's really hard to see how they change. Let's keep them wrapped at 78 characters, so that our console-based Email program that we're not using can handle them