chore: have 'use strict' consistently across our lib files (#14721)

lib/.eslintrc

@@ -0,0 +1,8 @@
+{
+  "parserOptions": {
+    "sourceType": "script"
+  },
+  "rules": {
+    "strict": ["error", "global"]
+  }
+}

lib/browser/api/auto-updater.js

@@ -1,3 +1,5 @@
+'use strict'
+
 if (process.platform === 'win32') {
   module.exports = require('@electron/internal/browser/api/auto-updater/auto-updater-win')
 } else {

lib/browser/api/auto-updater/auto-updater-native.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const EventEmitter = require('events').EventEmitter
 const { autoUpdater, AutoUpdater } = process.atomBinding('auto_updater')
 

lib/browser/api/auto-updater/squirrel-update-win.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fs = require('fs')
 const path = require('path')
 const spawn = require('child_process').spawn

lib/browser/api/content-tracing.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = process.atomBinding('content_tracing')

lib/browser/api/exports/electron.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const common = require('@electron/internal/common/api/exports/electron')
 // since browser module list is also used in renderer, keep it separate.
 const moduleList = require('@electron/internal/browser/api/module-list')

lib/browser/api/global-shortcut.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = process.atomBinding('global_shortcut').globalShortcut

lib/browser/api/ipc-main.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const EventEmitter = require('events').EventEmitter
 
 const emitter = new EventEmitter()

lib/browser/api/menu-item-roles.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { app } = require('electron')
 
 const roles = {

lib/browser/api/menu-utils.js

@@ -1,3 +1,5 @@
+'use strict'
+
 function splitArray (arr, predicate) {
   const result = arr.reduce((multi, item) => {
     const current = multi[multi.length - 1]

lib/browser/api/module-list.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const features = process.atomBinding('features')
 
 // Browser side modules, please sort alphabetically.

lib/browser/api/notification.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { Notification, isSupported } = process.atomBinding('notification')
 

lib/browser/api/power-monitor.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { powerMonitor, PowerMonitor } = process.atomBinding('power_monitor')
 

lib/browser/api/power-save-blocker.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = process.atomBinding('power_save_blocker').powerSaveBlocker

lib/browser/api/protocol.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { app, session } = require('electron')
 
 // Global protocol APIs.

lib/browser/api/screen.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { screen, Screen } = process.atomBinding('screen')
 

lib/browser/api/session.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { app } = require('electron')
 const { fromPartition, Session, Cookies } = process.atomBinding('session')

lib/browser/api/system-preferences.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { systemPreferences, SystemPreferences } = process.atomBinding('system_preferences')
 

lib/browser/api/touch-bar.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 
 let nextItemID = 1

lib/browser/api/tray.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { EventEmitter } = require('events')
 const { Tray } = process.atomBinding('tray')
 

lib/browser/chrome-extension.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { app, ipcMain, webContents, BrowserWindow } = require('electron')
 const { getAllWebContents } = process.atomBinding('web_contents')
 const renderProcessPreferences = process.atomBinding('render_process_preferences').forAllWebContents()

lib/common/api/clipboard.js

@@ -1,3 +1,5 @@
+'use strict'
+
 if (process.platform === 'linux' && process.type === 'renderer') {
   // On Linux we could not access clipboard in renderer process.
   module.exports = require('electron').remote.clipboard

lib/common/api/exports/electron.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const moduleList = require('@electron/internal/common/api/module-list')
 
 exports.memoizedGetter = (getter) => {

lib/common/api/module-list.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Common modules, please sort alphabetically
 module.exports = [
   { name: 'clipboard', file: 'clipboard' },

lib/common/api/native-image.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = process.atomBinding('native_image')

lib/common/api/shell.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = process.atomBinding('shell')

lib/common/asar.js

@@ -1,3 +1,5 @@
+'use strict';
+
 (function () {
   const asar = process.binding('atom_common_asar')
   const assert = require('assert')

lib/common/asar_init.js

@@ -1,3 +1,5 @@
+'use strict'
+
 ;(function () { // eslint-disable-line
   return function (process, require, asarSource) {
     const source = process.binding('natives')

lib/common/atom-binding-setup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 module.exports = function atomBindingSetup (binding, processType) {
   return function atomBinding (name) {
     try {

lib/common/buffer-utils.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Note: Don't use destructuring assignment for `Buffer`, or we'll hit a
 // browserify bug that makes the statement invalid, throwing an error in
 // sandboxed renderer.

lib/common/init.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const timers = require('timers')
 const util = require('util')
 

lib/common/parse-features-string.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // parses a feature string that has the format used in window.open()
 // - `features` input string
 // - `emit` function(key, value) - called for each parsed KV

lib/common/reset-search-paths.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const path = require('path')
 const Module = require('module')
 

lib/isolated_renderer/init.js

@@ -1,7 +1,7 @@
-/* global binding */
-
 'use strict'
 
+/* global binding */
+
 const { send, sendSync } = binding
 
 const ipcRenderer = {

lib/renderer/api/desktop-capturer.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { ipcRenderer, nativeImage } = require('electron')
 
 const includes = [].includes

lib/renderer/api/exports/electron.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const common = require('@electron/internal/common/api/exports/electron')
 const moduleList = require('@electron/internal/renderer/api/module-list')
 

lib/renderer/api/module-list.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const features = process.atomBinding('features')
 
 // Renderer side modules, please sort alphabetically.

lib/renderer/api/screen.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('electron').remote.screen

lib/renderer/chrome-api.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { ipcRenderer } = require('electron')
 const Event = require('@electron/internal/renderer/extensions/event')
 const url = require('url')

lib/renderer/content-scripts-injector.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { ipcRenderer } = require('electron')
 const { runInThisContext } = require('vm')
 

lib/renderer/extensions/event.js

@@ -1,3 +1,5 @@
+'use strict'
+
 class Event {
   constructor () {
     this.listeners = []

lib/renderer/extensions/i18n.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Implementation of chrome.i18n.getMessage
 // https://developer.chrome.com/extensions/i18n#method-getMessage
 //

lib/renderer/extensions/storage.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fs = require('fs')
 const path = require('path')
 const { remote } = require('electron')

lib/renderer/extensions/web-navigation.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const Event = require('@electron/internal/renderer/extensions/event')
 const { ipcRenderer } = require('electron')
 

lib/renderer/inspector.js

@@ -1,3 +1,5 @@
+'use strict'
+
 window.onload = function () {
   // Use menu API to show context menu.
   window.InspectorFrontendHost.showContextMenuAtPoint = createMenu

lib/renderer/security-warnings.js

@@ -1,3 +1,5 @@
+'use strict'
+
 let shouldLog = null
 
 /**

lib/renderer/web-frame-init.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { ipcRenderer, webFrame } = require('electron')
 const errorUtils = require('@electron/internal/common/error-utils')
 

lib/renderer/web-view/web-view-constants.js

@@ -1,3 +1,5 @@
+'use strict'
+
 module.exports = {
   // Attributes.
   ATTRIBUTE_NAME: 'name',

lib/renderer/window-setup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // This file should have no requires since it is used by the isolated context
 // preload bundle. Instead arguments should be passed in for everything it
 // needs.
@@ -21,8 +23,6 @@
 // - document.hidden
 // - document.visibilityState
 
-'use strict'
-
 const { defineProperty } = Object
 
 // Helper function to resolve relative url.

lib/sandboxed_renderer/api/exports/child_process.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('electron').remote.require('child_process')

lib/sandboxed_renderer/api/exports/electron.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const moduleList = require('@electron/internal/sandboxed_renderer/api/module-list')
 
 for (const {

lib/sandboxed_renderer/api/exports/fs.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('electron').remote.require('fs')

lib/sandboxed_renderer/api/exports/os.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('electron').remote.require('os')

lib/sandboxed_renderer/api/exports/path.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('electron').remote.require('path')

lib/sandboxed_renderer/api/ipc-renderer.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const ipcRenderer = require('@electron/internal/renderer/api/ipc-renderer')
 
 const v8Util = process.atomBinding('v8_util')

lib/sandboxed_renderer/api/module-list.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const features = process.atomBinding('features')
 
 module.exports = [

lib/sandboxed_renderer/init.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint no-eval: "off" */
 /* global binding, Buffer */
 const events = require('events')