Update shell/common/gin_converters/usb_protected_classes_converter.h

Co-authored-by: Charles Kerr <charles@charleskerr.com>
electron · May 15, 2023 · 5d27a15 · 5d27a15
1 parent 85141a9
commit 5d27a15
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/shell/common/gin_converters/usb_protected_classes_converter.h b/shell/common/gin_converters/usb_protected_classes_converter.h
@@ -48,10 +48,11 @@ struct Converter<electron::ElectronPermissionManager::USBProtectedClasses> {
       electron::ElectronPermissionManager::USBProtectedClasses* out) {
     std::vector<std::string> class_strings;
     if (ConvertFromV8(isolate, val, &class_strings)) {
-      for (auto itr : class_strings) {
-        for (auto const& [usb_class, name] : ClassMapping) {
-          if (static_cast<std::string>(name) == itr)
-            out->push_back(usb_class);
+      out->reserve(std::size(class_strings));
+      for (const auto& itr : class_strings) {
+        for (const auto& [usb_class, name] : ClassMapping) {
+          if (name == itr)
+            out->emplace_back(usb_class);
         }
       }
       return true;