Fix async context timer issue

electron · Feb 24, 2020 · e43d713 · e43d713
1 parent 4d72e13
commit e43d713
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/shell/app/node_main.cc b/shell/app/node_main.cc
@@ -152,9 +152,12 @@ int NodeMain(int argc, char* argv[]) {
     node_debugger.Start();
 
     node::BootstrapEnvironment(env);
+
+    // TODO(codebytere): we shouldn't have to call this - upstream?
     env->InitializeDiagnostics();
 
     // This is needed in order to enable v8 host weakref hooks.
+    // TODO(codebytere): we shouldn't have to call this - upstream?
     gin_env.isolate()->SetHostCleanupFinalizationGroupCallback(
         HostCleanupFinalizationGroupCallback);
 
@@ -181,7 +184,15 @@ int NodeMain(int argc, char* argv[]) {
       versions.SetReadOnly(ELECTRON_PROJECT_NAME, ELECTRON_VERSION_STRING);
     }
 
-    node::LoadEnvironment(env);
+    // TODO(codebytere): we should try to handle this upstream.
+    {
+      node::InternalCallbackScope callback_scope(
+          env, v8::Local<v8::Object>(), {1, 0},
+          node::InternalCallbackScope::kAllowEmptyResource |
+              node::InternalCallbackScope::kSkipAsyncHooks);
+      node::LoadEnvironment(env);
+    }
+
     v8::Isolate* isolate = env->isolate();
 
     {