Merge pull request #5870 from danhp/missing-roles

Add 'delete' and 'pasteandmatchstyle' roles
electron · Jun 6, 2016 · ec691a3 · ec691a3
2 parents 08f5322 + bd1eae8
commit ec691a3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm
@@ -33,7 +33,7 @@
   { @selector(copy:), "copy" },
   { @selector(paste:), "paste" },
   { @selector(delete:), "delete" },
-  { @selector(pasteAndMatchStyle:), "paste-and-match-style" },
+  { @selector(pasteAndMatchStyle:), "pasteandmatchstyle" },
   { @selector(selectAll:), "selectall" },
   { @selector(performMiniaturize:), "minimize" },
   { @selector(performClose:), "close" },

diff --git a/docs/api/menu-item.md b/docs/api/menu-item.md
@@ -46,7 +46,9 @@ The `role` property can have following values:
 * `cut`
 * `copy`
 * `paste`
+* `pasteandmatchstyle`
 * `selectall`
+* `delete`
 * `minimize` - Minimize current window
 * `close` - Close current window
 

diff --git a/lib/browser/api/menu-item.js b/lib/browser/api/menu-item.js
@@ -11,6 +11,7 @@ rolesMap = {
   cut: 'cut',
   copy: 'copy',
   paste: 'paste',
+  pasteandmatchstyle: 'pasteAndMatchStyle',
   selectall: 'selectAll',
   minimize: 'minimize',
   close: 'close',