Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'delete' and 'pasteandmatchstyle' roles #5870

Merged
merged 1 commit into from Jun 6, 2016

Conversation

Projects
None yet
2 participants
@danhp
Copy link
Member

danhp commented Jun 4, 2016

  • delete was already implemented so we simply need to add to the docs.
  • paste-and-match-style was already implemented on OS X side so we needed to map the corresponding action in web-contents for Linux and Windows.

Closes #5866
Closes #5867

'cut': 'cut',
'copy': 'copy',
'paste': 'paste',
'paste-and-match-style': 'pasteAndMatchStyle',

This comment has been minimized.

Copy link
@danhp

This comment has been minimized.

Copy link
@zcbenz

zcbenz Jun 6, 2016

Member

Current style for roles is to use all lower cases, like hideothers and selectall.

We should probably change them to lowerCamelCase in future to make the names consistent with other APIs.

@danhp danhp changed the title Add 'delete' and 'paste-and-match-style' roles Add 'delete' and 'pasteandmatchstyle' roles Jun 6, 2016

@danhp

This comment has been minimized.

Copy link
Member Author

danhp commented Jun 6, 2016

Updated paste-and-match-style to pasteandmatchstyle. I think it should be ok since it was never made public that the role existed.

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jun 6, 2016

👍

@zcbenz zcbenz merged commit ec691a3 into electron:master Jun 6, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danhp danhp deleted the danhp:missing-roles branch Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.