-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: [19-x-y] cherry-pick ec236fef54b8 from v8
- Loading branch information
Showing
2 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
From ec236fef54b801fcfd89342108cfe95d20db2fd8 Mon Sep 17 00:00:00 2001 | ||
From: Tobias Tebbi <tebbi@chromium.org> | ||
Date: Wed, 26 Oct 2022 11:19:59 +0200 | ||
Subject: [PATCH] Merged: [turbofan] do not optimize any stores for field type None | ||
|
||
Fixed: chromium:1378239 | ||
(cherry picked from commit db83e72034c0d431ff2f73e3c4ae3130c0f3e4e1) | ||
|
||
Change-Id: I061d5dfe6e4ee24e6d0e7df56e15fbe37752d51e | ||
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3982254 | ||
Reviewed-by: Tobias Tebbi <tebbi@chromium.org> | ||
Commit-Queue: Igor Sheludko <ishell@chromium.org> | ||
Cr-Commit-Position: refs/branch-heads/10.6@{#45} | ||
Cr-Branched-From: 41bc7435693fbce8ef86753cd9239e30550a3e2d-refs/heads/10.6.194@{#1} | ||
Cr-Branched-From: d5f29b929ce7746409201d77f44048f3e9529b40-refs/heads/main@{#82548} | ||
--- | ||
|
||
diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc | ||
index 024a803..4c89233 100644 | ||
--- a/src/compiler/access-info.cc | ||
+++ b/src/compiler/access-info.cc | ||
@@ -451,9 +451,15 @@ | ||
map, descriptor, details_representation)); | ||
} else if (details_representation.IsHeapObject()) { | ||
if (descriptors_field_type->IsNone()) { | ||
- // Store is not safe if the field type was cleared. | ||
- if (access_mode == AccessMode::kStore) { | ||
- return Invalid(); | ||
+ switch (access_mode) { | ||
+ case AccessMode::kStore: | ||
+ case AccessMode::kStoreInLiteral: | ||
+ case AccessMode::kDefine: | ||
+ // Store is not safe if the field type was cleared. | ||
+ return Invalid(); | ||
+ case AccessMode::kLoad: | ||
+ case AccessMode::kHas: | ||
+ break; | ||
} | ||
|
||
// The field type was cleared by the GC, so we don't know anything |