Changes to dialog api

[probablycorey]

In Atom, the open dialog is used to open a new window, or open a file in an existing window. So the api we need is a combination of dialog.openFile and dialog.openFolder where it doesn't matter if the user opens a file or a folder. We also could allow the user to open multiple files/folders.

So I propose we remove dialog.openMultiFiles dialog.openFile and dialog.openFolder with dialog.open

[zcbenz]

As with #9, current API follows Chromium's ui library, I'll reimplement the API along with changing the interface.

[zcbenz]

I'm now implementing the file dialog API for Windows, but the problem is: the standard Windows file dialog does not support selecting both files and directories, and there is no way to select multiple directories too. The same limitation exists in GTK+, so we would face the same problem when porting atom-shell on Linux.

The only solution is to create custom file dialogs, but the work would be quite large, and it's very hard to make them behave similar to the standard ones. So I think maybe we should just separate the open of files from directories in Atom?

/cc @probablycorey @kevinsawicki @nathansobo

[nathansobo]

@xpaulbettsx any advice on this? I'd love to keep the current behavior if we can.

[anaisbetts]

@nathansobo As @zcbenz says, Windows and GTK+ aren't down with a file chooser picking both files and folders, it's either one or the other. What scenario do you need to pick both? Windows >= Vista does allow you to pick multiple directories afaik

[probablycorey]

Does this mean you can't open multiple files and directories at the same
time in Windows and GTK+. Or does this mean there is no dialog that lets
you open a file or a directory (one dialog only opens directories, and
another only opens files).

In OS X it is very common to use the same dialog to open either a single
file or a single directory. So I think we need that functionality.

On Fri, Aug 2, 2013 at 10:59 AM, Paul Betts notifications@github.comwrote:

@nathansobo https://github.com/nathansobo As @zcbenzhttps://github.com/zcbenzsays, Windows and GTK+ aren't down with a file chooser picking both files
and folders, it's either one or the other. What scenario do you need to
pick both? Windows >= Vista does allow you to pick multiple directories
afaik

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22022617
.

[anaisbetts]

Does this mean you can't open multiple files and directories at the same time in Windows and GTK+

Exactly

In OS X it is very common to use the same dialog to open either a single file or a single directory

That part's fine

[probablycorey]

Ok, cool. I think it's fine if we can't open multiple files and directories
at the same time in OS X.

On Mon, Aug 5, 2013 at 11:03 AM, Paul Betts notifications@github.comwrote:

Does this mean you can't open multiple files and directories at the same
time in Windows and GTK+

Exactly

In OS X it is very common to use the same dialog to open either a single
file or a single directory

That part's fine

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22124534
.

[zcbenz]

@xpaulbettsx do you mean that it's possible to use the same dialog to select either file or folder on Windows with Win32 API? Where can I find the related documentation or example?

[anaisbetts]

@zcbenz Sure, check out http://msdn.microsoft.com/en-us/library/windows/desktop/bb776913(v=vs.85).aspx - afaik it's simply a matter of including / not including FOS_PICKFOLDERS

Also, this code is not nearly as ugly as it looks, the Explorer team bans more than one return statement in a method, because they love code that looks like this:

                    }
                }

                delete bar;
            }
        }
    }
}

[zcbenz]

@xpaulbettsx Thanks for the link!

So on Windows we could support following dialogs:

1. dialog to open single/multiple files
2. dialog to open single folder
3. dialog to open multiple folders (only on Windows >= Vista)
4. dialog to open single file or folder (only on Windows >= Vista)

@nathansobo @probablycorey Is it OK to discard Windows XP for Atom?

[anaisbetts]

Is it OK to discard Windows XP for Atom?

Please don't launch with XP support, it's a twelve-year old operating system. We don't support OS X 10.1 either, despite it actually being a month younger than Windows XP.

[probablycorey]

@zcbenz I'd be happy to support Windows >= Vista.

On Tue, Aug 6, 2013 at 5:18 AM, Paul Betts notifications@github.com wrote:

Is it OK to discard Windows XP for Atom?

Please don't launch with XP support, it's a twelve-year old operating
system. We don't support OS X 10.1http://en.wikipedia.org/wiki/Mac_OS_X_v10.1despite it actually being a month younger than Windows XP.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22174685
.

[zcbenz]

Close this for favor of #76.