Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code signing tutorial #12767

Merged
merged 4 commits into from
May 2, 2018
Merged

add code signing tutorial #12767

merged 4 commits into from
May 2, 2018

Conversation

zeke
Copy link
Contributor

@zeke zeke commented May 1, 2018

This PR adds a basic tutorial about code signing: what is is, why you need to do it, and how to get started for macOS and Windows.

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Zeke!

@ckerr ckerr merged commit f1c7df8 into master May 2, 2018
@ckerr ckerr deleted the code-signing branch May 2, 2018 00:56

# Signing Windows builds

See the [Windows Store Guide].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this guide actually covers codesigning applications on Windows that don't go to the store (which is what 99% of people do)

I'll make a PR to follow up to this with some more changes 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarshallOfSound 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants