Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck-provider never called, spellchecking thus broken #13608

Closed
felixrieseberg opened this issue Jul 10, 2018 · 1 comment
Closed

Spellcheck-provider never called, spellchecking thus broken #13608

felixrieseberg opened this issue Jul 10, 2018 · 1 comment
Assignees
@nornagon
Labels
3-0-x app-feedback-program bug 🪲 bug/regression ↩️ A new version of Electron broke something platform/macOS

Comments

@felixrieseberg
Copy link
Member

  • Electron Version: 3.0.0-beta.1
  • Operating System (Platform and Version): macOS 10.13 (but all others seem affected, too)
  • Last known working Electron version: 2.0.x

Expected Behavior
Spellchecking should work: After calling webFrame.setSpellCheckProvider with a given provider, that provider's spellCheck() method should be called.

Actual behavior
Calling webFrame.setSpellCheckProvider seems to have no effect - the provider is simply never called.

To Reproduce
Clone the repo below and start the app. The spellcheck provider is configured to log each input word. However, it appears that spellCheck is never called.

git clone https://github.com/felixrieseberg/electron-3-spellcheck
cd electron-3-spellcheck
npm install
npm start || electron .
@felixrieseberg felixrieseberg added bug 🪲 bug/regression ↩️ A new version of Electron broke something 3-0-x labels Jul 10, 2018
@felixrieseberg felixrieseberg changed the title Spellcheck Provider never called Spellcheck-provider never called, spellchecking thus broken Jul 10, 2018
@nornagon nornagon self-assigned this Jul 10, 2018
nornagon added a commit to nornagon/electron that referenced this issue Jul 10, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
c2beb00 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes electron#13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
nornagon added a commit to nornagon/electron that referenced this issue Jul 10, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
8af7619 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes electron#13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
@nornagon nornagon mentioned this issue Jul 10, 2018
Merged
4 tasks
@sofianguy sofianguy added this to App Feedback Program in 3.0.x / 3.1.x Jul 10, 2018
@sofianguy sofianguy moved this from App Feedback Program to PR In Flight in 3.0.x / 3.1.x Jul 10, 2018
@sofianguy sofianguy removed this from PR In Flight in 3.0.x / 3.1.x Jul 10, 2018
nornagon added a commit to nornagon/electron that referenced this issue Jul 10, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
0681e4c 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes electron#13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
nornagon added a commit to nornagon/electron that referenced this issue Jul 11, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
0413267 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes electron#13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
nornagon added a commit that referenced this issue Jul 11, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
bdceea6 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes #13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
trop-bot pushed a commit to trop-bot/electron that referenced this issue Jul 12, 2018
@nornagon @electron-bot
fix: enable spell checking, which broke in upgrade to ch66
25d1f3f 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes electron#13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
@ckerr
Copy link
Member

ckerr commented Jul 12, 2018

3-0-x branch by trop: #13650

nornagon added a commit that referenced this issue Jul 12, 2018
@nornagon
fix: enable spell checking, which broke in upgrade to ch66
041c952 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes #13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
@fxha fxha mentioned this issue Jan 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nornagon nornagon

Labels
3-0-x app-feedback-program bug 🪲 bug/regression ↩️ A new version of Electron broke something platform/macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ckerr @nornagon @felixrieseberg @sofianguy