API tray.destroy is not working #17622

rhythm-sharma · 2019-03-30T13:38:50Z

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

Electron Version:
- 4.0.4
Operating System:
- Ubuntu 18.10 x64

Expected Behavior

Observed in Zulip desktop app

tray.destroy() api should destroy tray icon in panel
show app tray icon option in general setting, it should destroy and create tray icon on toggle

Actual Behavior

Previous tray icon are not destroy on toggle and new icon created i.e tray.destroy API is not working

To Reproduce

$ git clone https://github.com/zulip/zulip-electron
$ cd zulip-electron
$ npm install
$ npm start

you can find code in zulip-electron/app/renderer/js/tray.js

function toggleTray() {
	let state;
	if (window.tray) {
		state = false;
		window.tray.destroy();
		if (window.tray.isDestroyed()) {
			window.tray = null;
		}
		ConfigUtil.setConfigItem('trayIcon', false);
	} else {
		state = true;
		createTray();
		if (process.platform === 'linux' || process.platform === 'win32') {
			renderNativeImage(unread).then(image => {
				window.tray.setImage(image);
				window.tray.setToolTip(unread + ' unread messages');
			});
		}
		ConfigUtil.setConfigItem('trayIcon', true);
	}
	const selector = 'webview:not([class*=disabled])';
	const webview = document.querySelector(selector);
	const webContents = webview.getWebContents();
	webContents.send('toggletray', state);
}

Screenshots

The text was updated successfully, but these errors were encountered:

rhythm-sharma · 2019-03-30T13:44:12Z

@MarshallOfSound can you please review this ?

chfanghr · 2019-03-30T13:45:10Z

my work around:Spawn a new process to show tray

chfanghr · 2019-03-30T13:48:27Z

KDE and GNOME have the same ploblem that caused by the desktop itself,so the only thing we can do is to work around.

rhythm-sharma · 2019-03-30T13:49:19Z

@chfanghr okay got you point, thanks for you help

rhythm-sharma · 2019-03-30T13:50:30Z

KDE and GNOME have the same ploblem that caused by the desktop itself,so the only thing we can do is to work around.

i tried alt + f2 -> r, it solve this on temporary basis

chfanghr · 2019-03-30T14:25:48Z

will,brilliant,i will have a try

rhythm-sharma · 2019-03-30T14:31:19Z

@chfanghr
Though, I hit this Gnome Shell bug, and my Gnome crashed a couple of times, before I figured out what was happening!

chfanghr · 2019-03-30T14:39:12Z

you should try kde,at least it doesn't crash

rhythm-sharma · 2019-03-30T14:56:42Z

@chfanghr i read about GtkStatusIcon in Tray documentation here under Platform limitations section, would you please tell me how to install it in ubuntu

chfanghr · 2019-03-31T04:50:44Z

Instructions here.Also ,you can use kubuntu image directly.

chfanghr · 2019-03-31T04:53:45Z

And you may have to replace your login manager with sddm.

rhythm-sharma · 2019-03-31T04:55:25Z

I don't know much about GtkStatusicon, if you know something then tell me about it(how to install)

chfanghr · 2019-03-31T05:00:47Z

Oh sorry .GtkStatusion is a part of gnome so you don't have to install it Manually . As for libappindicator1 ,you can install it with apt .But actually it doesn't solve this issue.

rhythm-sharma · 2019-03-31T05:03:56Z

Thanks, okay it cleared my concept

chfanghr · 2019-03-31T05:06:29Z

If you want a better Tray experience,you may want to try qt.But I wonder how they achieve it.

rhythm-sharma · 2019-03-31T05:09:18Z

Hmm Zulip-desktop is based on electron a single person can't change the codebase 😄

chfanghr · 2019-03-31T05:26:59Z

Using KDE's native API sovle this issue,but that's annoying....

rhythm-sharma · 2019-03-31T05:28:17Z

can you provide a link for KDE native API

chfanghr · 2019-03-31T05:33:14Z

https://api.kde.org/pykde-4.4-api/kdeui/KSystemTrayIcon.html

chfanghr · 2019-03-31T05:34:13Z

But now I have to manage my codebase in five languages...GOD DAME

rhythm-sharma · 2019-03-31T05:35:56Z

that's really annoying 😆

chfanghr · 2019-03-31T05:58:21Z

Perhaps you can rewrite the application with PWA and wasm.Though you need chrome ,the user experience will be better on every platforms.

chfanghr · 2019-03-31T06:19:03Z

check this : https://techbase.kde.org/Projects/Plasma/NewSystemTray

rhythm-sharma · 2019-04-02T07:33:53Z

@chfanghr i had exams so sorry for late responding, I think it would be a bad option for me to dive deeper into the OS because I do not know much about them, I think we should see how other apps(like skype etc based on electron) are solving this issue because it is a problem with electron and linux

chfanghr · 2019-04-04T13:34:48Z

ok,did you make any progress?

rhythm-sharma · 2019-04-04T13:37:48Z

No progress, Skype don't interfere with tray icon, though I saw some issue on tray icon is not showing up but they didn't solve the problem

chfanghr · 2019-04-09T01:52:56Z

Update https://github.com/meetfranz/franz/issues/1377

Bilb · 2021-08-13T05:30:14Z

Just bumped from electron

"electron": "8.2.0",
to

"electron": "^13.1.9",

and this bug started to appear. The destroy was working correctly before that.

Relates #electron/electron#17622

Tray.destroy() is not working on Linux due to: electron/electron#17622 Which causes tray icon to duplicate on every init.

github-actions · 2022-10-08T02:21:40Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

itsPG · 2022-10-08T08:12:42Z

same on v17.4.11.

haven't tried the latest v21 though.

github-actions · 2023-01-10T02:10:15Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

itsPG · 2023-01-10T05:28:51Z

Still reproducable on v17.4.11.

Hope someoe who encounters this issue could help us test the latest version.

I used a deprecated API and cannot upgrade right now.

github-actions · 2023-04-12T01:56:27Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

rak-phillip · 2023-05-03T21:04:48Z

Not stale, able to repro on electron v20.3.8 in Ubuntu 22.04 Gnome. Would like to update to latest stable version of electron to confirm that this is still a problem.

github-actions · 2023-08-03T01:52:13Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

electron-issue-triage · 2023-11-09T01:49:33Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

electron-issue-triage · 2023-12-10T01:51:16Z

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

viktordw · 2024-01-17T10:00:01Z

This was closed due to inactivity, but It seems this is still not resolved.
There is an active issue for keeweb project that is related to this.

sofianguy added 4-2-x bug 🪲 platform/linux labels Apr 2, 2019

Bilb added a commit to Bilb/session-desktop that referenced this issue Aug 13, 2021

fix tray cannot be destroyed

1af0831

Relates #electron/electron#17622

aleksey-hoffman added a commit to aleksey-hoffman/sigma-file-manager that referenced this issue Aug 25, 2021

fix: linux: tray icon duplicates on init

1176d7d

Tray.destroy() is not working on Linux due to: electron/electron#17622 Which causes tray icon to duplicate on every init.

newhinton mentioned this issue Dec 4, 2021

do not re-add tray on linux Zettlr/Zettlr#2842

Closed

msojocs mentioned this issue May 16, 2022

[Bug] 托盘图标问题 msojocs/bilibili-linux#6

Closed

github-actions bot added the stale label Oct 8, 2022

github-actions bot removed the stale label Oct 9, 2022

github-actions bot added the stale label Jan 10, 2023

github-actions bot removed the stale label Jan 11, 2023

github-actions bot added the stale label Apr 12, 2023

rak-phillip mentioned this issue May 3, 2023

On Ubuntu, trying to hide the notification icon fails to remove the tray icon rancher-sandbox/rancher-desktop#4205

Closed

github-actions bot removed the stale label May 4, 2023

sunilarjun mentioned this issue May 16, 2023

Tray Icon Issue Docs Update rancher-sandbox/docs.rancherdesktop.io#214

Closed

github-actions bot added the stale label Aug 3, 2023

codebytere added 26-x-y and removed 4-2-x stale labels Aug 4, 2023

codebytere removed their assignment Aug 10, 2023

electron-issue-triage bot added the stale label Nov 9, 2023

electron-issue-triage bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023

API tray.destroy is not working #17622

API tray.destroy is not working #17622

Comments

rhythm-sharma commented Mar 30, 2019 • edited Loading

Preflight Checklist

Issue Details

Expected Behavior

Actual Behavior

To Reproduce

Screenshots

rhythm-sharma commented Mar 30, 2019

chfanghr commented Mar 30, 2019

chfanghr commented Mar 30, 2019

rhythm-sharma commented Mar 30, 2019 • edited Loading

rhythm-sharma commented Mar 30, 2019

chfanghr commented Mar 30, 2019 via email • edited Loading

rhythm-sharma commented Mar 30, 2019

chfanghr commented Mar 30, 2019

rhythm-sharma commented Mar 30, 2019 • edited Loading

chfanghr commented Mar 31, 2019

chfanghr commented Mar 31, 2019

rhythm-sharma commented Mar 31, 2019

chfanghr commented Mar 31, 2019

rhythm-sharma commented Mar 31, 2019

chfanghr commented Mar 31, 2019

rhythm-sharma commented Mar 31, 2019 • edited Loading

chfanghr commented Mar 31, 2019

rhythm-sharma commented Mar 31, 2019 • edited Loading

chfanghr commented Mar 31, 2019

chfanghr commented Mar 31, 2019

rhythm-sharma commented Mar 31, 2019

chfanghr commented Mar 31, 2019

chfanghr commented Mar 31, 2019

rhythm-sharma commented Apr 2, 2019 • edited Loading

chfanghr commented Apr 4, 2019

rhythm-sharma commented Apr 4, 2019 • edited Loading

chfanghr commented Apr 9, 2019

Bilb commented Aug 13, 2021

github-actions bot commented Oct 8, 2022

itsPG commented Oct 8, 2022

github-actions bot commented Jan 10, 2023

itsPG commented Jan 10, 2023

github-actions bot commented Apr 12, 2023

rak-phillip commented May 3, 2023

github-actions bot commented Aug 3, 2023

electron-issue-triage bot commented Nov 9, 2023

electron-issue-triage bot commented Dec 10, 2023

viktordw commented Jan 17, 2024

rhythm-sharma commented Mar 30, 2019 •

edited

Loading

rhythm-sharma commented Mar 30, 2019 •

edited

Loading

chfanghr commented Mar 30, 2019 via email •

edited

Loading

rhythm-sharma commented Mar 30, 2019 •

edited

Loading

rhythm-sharma commented Mar 31, 2019 •

edited

Loading

rhythm-sharma commented Mar 31, 2019 •

edited

Loading

rhythm-sharma commented Apr 2, 2019 •

edited

Loading

rhythm-sharma commented Apr 4, 2019 •

edited

Loading