build: fix ffmpeg gn gen #19127
Merged
build: fix ffmpeg gn gen #19127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2019 15:23
zcbenz
approved these changes
Jul 8, 2019
|
No Release Notes |
6 tasks
nornagon
reviewed
Jul 8, 2019
| @@ -4,3 +4,4 @@ is_component_ffmpeg = true | |||
| is_official_build = true | |||
| proprietary_codecs = false | |||
| ffmpeg_branding = "Chromium" | |||
| enable_dsyms = false | |||
There was a problem hiding this comment.
hm, ideally we'd still generate symbols for this build, though i'm not sure we currently have a place to publish them.
seems like a good fix for now though 👍
... how come this didn't get caught by CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Somehow #19042 broke non proprietary ffmpeg GN gen. This PR fixes that. It also reverts #18993 because that PR introduced a security hole and prevented commits on linux and mac.
Checklist
Release Notes
Notes: no-notes