Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when building with enable_plugins=false #20354

Merged
merged 3 commits into from Oct 9, 2019
Merged

fix: when building with enable_plugins=false #20354

merged 3 commits into from Oct 9, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 27, 2019 •
edited

Description of Change

Fix building with enable_plugins=false

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2019
@miniak miniak self-assigned this Sep 27, 2019
@miniak miniak marked this pull request as ready for review September 27, 2019 16:22
@miniak miniak added the wip ⚒ label Sep 27, 2019
@miniak miniak force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from ca61fd7 to 996318a Compare September 28, 2019 09:03
@miniak miniak requested a review from a team as a code owner September 28, 2019 09:03
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2019
@miniak miniak force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from 996318a to 08da944 Compare October 1, 2019 07:16
@miniak miniak removed their assignment Oct 2, 2019
@miniak
Copy link
Contributor Author

miniak commented Oct 7, 2019

@nornagon do you want us to upstream the Chromium patch before merging this PR?

@miniak miniak requested a review from nornagon October 7, 2019 15:32
@deepak1556
Copy link
Member

Patch uploaded at https://chromium-review.googlesource.com/c/chromium/src/+/1845624

@deepak1556
Copy link
Member

Have updated the patches from upstream. Should be good to go once build is finished.

@deepak1556 deepak1556 force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from 9f77022 to 3951a04 Compare October 8, 2019 22:03
@deepak1556 deepak1556 removed their request for review October 8, 2019 22:03
@codebytere codebytere merged commit bb2ab01 into master Oct 9, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2019

No Release Notes

@codebytere codebytere deleted the miburda/fix_when_building_with_enable_plugins_false branch October 9, 2019 17:59
@trop
Copy link
Contributor

trop bot commented Oct 9, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 9, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

miniak added a commit that referenced this pull request Oct 9, 2019
@miniak
fix: when building with enable_plugins=false (#20354)
e9c397f
miniak added a commit that referenced this pull request Oct 9, 2019
@miniak
fix: when building with enable_plugins=false (#20354)
7bafb6a
miniak added a commit that referenced this pull request Oct 9, 2019
@miniak
fix: when building with enable_plugins=false (#20354)
9eadacb
miniak added a commit that referenced this pull request Oct 9, 2019
@miniak
fix: when building with enable_plugins=false (#20354)
0484be5
@miniak miniak mentioned this pull request Oct 9, 2019
Merged
3 tasks
@trop
Copy link
Contributor

trop bot commented Oct 9, 2019

@miniak has manually backported this PR to "7-0-x", please check out #20507

@miniak miniak mentioned this pull request Oct 9, 2019
Merged
3 tasks
@trop
Copy link
Contributor

trop bot commented Oct 9, 2019

@miniak has manually backported this PR to "6-0-x", please check out #20508

miniak added a commit that referenced this pull request Oct 9, 2019
@miniak
fix: when building with enable_plugins=false (#20354)
9fa82d6
codebytere pushed a commit that referenced this pull request Oct 10, 2019
@miniak @codebytere
fix: when building with enable_plugins=false (#20354) (#20508)
ffb96ac
@miniak miniak mentioned this pull request Jul 7, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @deepak1556 @nornagon @alexeykuzmin @zcbenz @codebytere