Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix building with enable_plugins = false #30040

Merged
merged 1 commit into from
Jul 8, 2021
Merged

build: fix building with enable_plugins = false #30040

merged 1 commit into from
Jul 8, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 7, 2021 •
edited

Description of Change

Follow-up to #20354. Caused by https://source.chromium.org/chromium/chromium/src/+/9bec86a5335c6f8bfbf002ef3c023c8d7e38c143

In file included from ../../electron/shell/browser/api/electron_api_web_contents.cc:49:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
#error "Plugins should be enabled"
 ^
1 error generated.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@miniak miniak self-assigned this Jul 7, 2021
@deepak1556 deepak1556 merged commit 13bf2fd into main Jul 8, 2021
@deepak1556 deepak1556 deleted the miniak/plugin-service branch July 8, 2021 07:18
@release-clerk
Copy link

release-clerk bot commented Jul 8, 2021

No Release Notes

@trop trop bot mentioned this pull request Jul 8, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jul 8, 2021

I have automatically backported this PR to "14-x-y", please check out #30049

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@miniak @BlackHole1
build: fix building with enable_plugins = false (electron#30040)
e39db38
This was referenced Aug 8, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @nornagon @deepak1556