7.1.X: A lot of seemingly random crashes because of "display::win::ScreenWin::UpdateFromDisplayInfos"

[aabuhijleh]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Electron Version:
  • Electron 7.1.3 (32-bit)
• Operating System:
  • Windows 10 Version 18362

Behavior

The app (main process) seems to crash a lot at std::vector<display::win::DisplayInfo,std::allocatordisplay::win::DisplayInfo >::_Emplace_reallocate<const display::win::DisplayInfo &> according to crash reports.

Even though I'm not sure how to reproduce, I think I should report these crashes. Maybe someone can help determine the cause of these crashes or check if there is a race condition in the internal design that no "outsider" can easily determine the steps for reproducing.

This might be related to #21158 because this is happening to the same set of users who suffered from that issue and were updated to Electron v7 from Electron v5

Stack

• [HERE] std::vector<display::win::DisplayInfo,std::allocatordisplay::win::DisplayInfo >::_Emplace_reallocate<const display::win::DisplayInfo &>

• display::win::ScreenWin::UpdateFromDisplayInfos(std::vector<display::win::DisplayInfo,std::allocatordisplay::win::DisplayInfo > const &)

• display::win::ScreenWin::UpdateAllDisplaysAndNotify()

• display::win::ScreenWin::OnWndProc(HWND__ *,unsigned int,unsigned int,long)

• base::internal::Invoker<base::internal::BindState<bool (device::RawInputDataFetcher::*)(unsigned int, unsigned int, long, long *) attribute((thiscall)),base::internal::UnretainedWrapperdevice::RawInputDataFetcher >,bool (unsigned int, unsigned int, long, long *)>::Run

• gfx::SingletonHwnd::ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)

...

[aabuhijleh]

I think I'm able to reproduce this issue now and I don't think it's related to #21158 anymore.

I will edit the description and add new details...

[aabuhijleh]

I opened #21614 instead of this issue