Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 9.0.0-beta.24 missing signature (macOS) #23534

Closed
pfrazee opened this issue May 12, 2020 · 5 comments · Fixed by electron/osx-sign#228
Closed

Electron 9.0.0-beta.24 missing signature (macOS) #23534

pfrazee opened this issue May 12, 2020 · 5 comments · Fixed by electron/osx-sign#228
Assignees
@MarshallOfSound

Comments

@pfrazee
Copy link
Contributor

pfrazee commented May 12, 2020

When I attempt to build 9.0.0-beta.24, codesign fails with "Electron Framework: code object is not signed at all". This doesn't occur for beta.22 so I assume the published build is just missing its signature (?).
pfrazee added a commit to beakerbrowser/beaker that referenced this issue May 12, 2020
@pfrazee
Revert to electron@9.0.0-beta.22 until code signature issue is resolv…
cb8e9ce 
…ed (electron/electron#23534)
@MarshallOfSound MarshallOfSound self-assigned this May 12, 2020
@nornagon
Copy link
Member

Seems like this is likely related to the crashpad binary having changed name.

@MarshallOfSound MarshallOfSound mentioned this issue May 12, 2020
Merged
@MarshallOfSound MarshallOfSound mentioned this issue May 13, 2020
Closed
@omarkilani omarkilani mentioned this issue May 19, 2020
Closed
@idanwork idanwork mentioned this issue May 20, 2020
Closed
@dkadrios
Copy link

This seems to be happening still in the 9.0.0 release? Getting 'code object is not signed at all' in subcomponent 'chrome_crashpad_handler'

@MarshallOfSound
Copy link
Member

This isn't a problem with electron, this is a flaw in your codesigning logic, if you're using electron-osx-sign you must update to the latest, if you're using something else unfortunately you're on your own with that.

@vitalykarasik
Copy link

I have the same issue, started after upgrade to Electron 9.0.0.

  • I upgraded to the latest "electron-osx-sign": "0.4.17"
  • added '--deep' into node_modules/app-builder-lib/electron-osx-sign/sign.js

without success.
Any ideas?

@troeggla
Copy link

This happened to me too after upgrading to Electron 9.1.0. Upgrading electron-builder to version 22.7.0 solved the issue though.

@raymondjacobson raymondjacobson mentioned this issue Jun 9, 2021
Merged
feret pushed a commit to Kappa-Dev/KappaTools that referenced this issue Jan 25, 2023
Add version number for electron-builder (electron/electron#23534 (com…
ecbd6ed 
…ment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sign child paths in order of depth electron/osx-sign
6 participants
@nornagon @dkadrios @pfrazee @troeggla @MarshallOfSound @vitalykarasik