Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign child paths in order of depth #228

Merged
merged 1 commit into from May 12, 2020
Merged

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented May 12, 2020

Well this is silly, but hey, 🤷‍♂️

Fixes electron/electron#23534

Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terrifying

@MarshallOfSound MarshallOfSound merged commit d99eebd into master May 12, 2020
@MarshallOfSound MarshallOfSound deleted the fix-electron-9 branch May 12, 2020 21:48
pfrazee added a commit to pfrazee/electron-builder that referenced this pull request May 20, 2020
csett86 added a commit to csett86/jitsi-meet-electron that referenced this pull request May 20, 2020
develar pushed a commit to electron-userland/electron-builder that referenced this pull request May 26, 2020
niik added a commit to desktop/desktop that referenced this pull request Aug 4, 2020
We need electron/osx-sign#228 to be able to sign on macOS (I think)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 9.0.0-beta.24 missing signature (macOS)
2 participants