Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: MenuItem click handler is not typed #24144

Closed
bpasero opened this issue Jun 16, 2020 · 0 comments · Fixed by #24147
Closed

TypeScript: MenuItem click handler is not typed #24144

bpasero opened this issue Jun 16, 2020 · 0 comments · Fixed by #24147

Comments

@bpasero
Copy link
Contributor

bpasero commented Jun 16, 2020

Referring to https://www.electronjs.org/docs/api/menu-item#new-menuitemoptions

The click handler is typed as Function inside the electron.d.ts. And the documentation is wrong around the browserWindow property being BrowserWindow. It can be undefined on macOS when no window is opened.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix MenuItem click handler type electron/electron
1 participant
@bpasero