Keyboard shortcuts: Fix Ctrl+G and other intermittently-firing shortcuts on Win/Linux

[codebykat]

Fix

Fixes #2420

Some keyboard shortcuts were silently failing on Win/Linux builds. After adding logging and debugging this I was able to determine that the if focusedWindow check was failing. I still don't know exactly why, as this works on OSX.

Changing it to explicitly check if the focusedWindow is undefined seems to fix the issue in my testing. I have only tested this on Windows, not Linux.

After some research, I think it would be safe to remove this guard entirely. The documentation does state that it can be undefined, but only in the case where no window is open, which only applies to OSX. (confirmed by a comment here)

Test

1. Download the Windows and/or Linux builds from CircleCI
2. Try all keyboard shortcuts, including Ctrl+G, and verify they all work with no errors in the console

Release

Fixed a bug that caused Ctrl+G and some other shortcuts to fail on Windows/Linux builds

[sandymcfadden]

I've been testing on Linux and the only one that doesn't seem to be working as expected is the open tag list Ctrl + Shift + U. If you are focused on the editor this doesn't fire while all others seem to.

It does work on the Mac build as expected. Should this be moved into the handleBrowserShortcut function?

[codebykat]

I've been testing on Linux and the only one that doesn't seem to be working as expected is the open tag list Ctrl + Shift + U. If you are focused on the editor this doesn't fire while all others seem to.

Hmm. It works on Windows for me, regardless of what has focus.

Are you on Ubuntu? Is it possible Ubuntu is eating it? https://superuser.com/questions/358749/how-to-disable-ctrlshiftu-in-ubuntu-linux

Also, how does this compare to the functionality in the 2.7.0 and/or 2.6.0 releases? I don't know if this shortcut gets much use, so maybe it's never worked properly..

[sandymcfadden]

You're right this seems to be the case that it is a global keyboard shortcut on some versions of Linux. I tried on 2.6.0 and had the same issue. Should we look at changing this shortcut, or be OK with it not working on Linux?

[codebykat]

I'm going to merge this for 2.8.0 to get the Windows shortcuts fixed, and open a follow-up issue. Thanks @sandymcfadden!