v1.46 New file/window menu items not functional with no window open

[richardowen]

Versions

• VSCode Version: 1.46.0
• OS Version: macOS 10.15.5 (Darwin x64 19.5.0)

Overview

In v1.46, the new file & new window menu items do not do anything when all windows are closed. The behaviour is the same with the keyboard shortcuts (Cmd+N, Cmd+Shift+N).

The bug is not present in v1.45.1.
The bug is present in the insiders build.

Steps to Reproduce

1. Open Visual Studio Code
2. Close all windows
3. From the File menu, choose either "New File" or "New Window"

Expected Result

1. A new file or window is opened

Actual Result

1. Nothing happens

Does this issue occur when all extensions are disabled?: Yes

[gjsjohnmurray]

Duplicate of #99831 but this one has a better title and clearer description, and reports the problem occurring from menu options as well as keybindings.

I was not able to reproduce it on Windows, so it seems to be macOS-specific.

[richardowen]

Yep it's the same issue. I'm afraid I didn't find that one while searching for duplicates.

[sbatten]

I haven't found out the cause yet, but I can repro.

[sbatten]

Looks like it was introduced by this change. 5356ceb

win is undefined when no window is open

vscode/src/vs/platform/menubar/electron-main/menubar.ts

Lines 116 to 119 in 5356ceb

	this.fallbackMenuHandlers['workbench.action.files.newUntitledFile'] = (menuItem, win, event) => this.windowsMainService.openEmptyWindow({ context: OpenContext.MENU, contextWindowId: win.id });
	this.fallbackMenuHandlers['workbench.action.newWindow'] = (menuItem, win, event) => this.windowsMainService.openEmptyWindow({ context: OpenContext.MENU, contextWindowId: win.id });
	this.fallbackMenuHandlers['workbench.action.files.openFileFolder'] = (menuItem, win, event) => this.electronMainService.pickFileFolderAndOpen(undefined, { forceNewWindow: this.isOptionClick(event), telemetryExtraData: { from: telemetryFrom } });
	this.fallbackMenuHandlers['workbench.action.openWorkspace'] = (menuItem, win, event) => this.electronMainService.pickWorkspaceAndOpen(undefined, { forceNewWindow: this.isOptionClick(event), telemetryExtraData: { from: telemetryFrom } });

[tabaddor]

Is this still unresolved? I can't seem to reproduce this issue.

[bpasero]

@sbatten thanks for the fix, yes this was a regression I introduced. I filed electron/electron#24144 because the TypeScript types are not catching this issue.