window.open does not accept size values with "px" at the end

[t57ser]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Electron Version:
  • 10.1.4
• Operating System:
  • Windows
• Last Known Working Electron version:
  • 9.3.2

Expected Behavior

The window should open with the correct size

Actual Behavior

The size is ignored

To Reproduce

Use nativeWindowOpen and do: window.open("", "", "width=300px")

Additional Information

This is working in chrome and firefox and was working in electron 9. If the event is intercepted via webContents.on("new-window") then the value is shown as NAN,

[nornagon]

Looks like this was caused by #23130, and should be fixed by using parseInt() instead of Number() here:

electron/lib/common/parse-features-string.ts

Line 41 in 22cb3cd

return Number(value);

[Code-Blooded-Human]

Hello, I would like to solve this issue.

[codebytere]

@Code-Blooded-Human in the future, please note when someone is assigned to an issue that means it's already being worked on - this causes collided work.