setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) api cause app dismiss in macOS dock #26350

fanlion · 2020-11-05T12:38:52Z

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

Electron Version:
- 10.1.5
Operating System:
- macOS 10.15.7 (19H2)
Last Known Working Electron version:
- unknow

Expected Behavior

after setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) , app should visible in macOS dock

Actual Behavior

after setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) , app is invisible in macOS dock

To Reproduce

git clone https://github.com/electron/electron-quick-start
add mainWindow.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }); in main.js
yarn start
watch your macOS dock

Screenshots

Additional Information

maybe it cause by visibleOnFullScreen: true，when app‘s icon dismiss from dock, app.dock.show() is not work. electron@9.2.1 is work, but visibleOnFullScreen: true is removed.

The text was updated successfully, but these errors were encountered:

asc0910 · 2020-11-06T23:06:35Z

Same with electron9.3.3

void NativeWindowMac::SetVisibleOnAllWorkspaces(bool visible,
                                                bool visibleOnFullScreen) {
  // In order for NSWindows to be visible on fullscreen we need to functionally
  // mimic app.dock.hide() since Apple changed the underlying functionality of
  // NSWindows starting with 10.14 to disallow NSWindows from floating on top of
  // fullscreen apps.
  ProcessSerialNumber psn = {0, kCurrentProcess};
  if (visibleOnFullScreen) {
    [window_ setCanHide:NO];
    TransformProcessType(&psn, kProcessTransformToUIElementApplication);
  } else {
    [window_ setCanHide:YES];
    TransformProcessType(&psn, kProcessTransformToForegroundApplication);
  }

  SetCollectionBehavior(visible, NSWindowCollectionBehaviorCanJoinAllSpaces);
  SetCollectionBehavior(visibleOnFullScreen,
                        NSWindowCollectionBehaviorFullScreenAuxiliary);
}

This makes the app dismiss from dock.

TransformProcessType(&psn, kProcessTransformToUIElementApplication);

No idea without setting this?

oltreseba · 2020-11-25T18:49:42Z

It looks like it's happening in electron 11.0.3 as well.

It was working fine in electron 9.1.1

yarinsa · 2021-01-19T16:11:18Z

try to use electron-panel-window to prevent this behavior

oltreseba · 2021-01-19T17:06:25Z

I don't think this is currently a doable way as:

electron-panel-window has not been updated in two years
It does not support macos big sur (macOS 10.16 (Big Sur) support goabstract/electron-panel-window#6)

lacymorrow · 2021-01-29T16:47:50Z

The visibleOnFullScreen option was removed from setVisibleOnAllWorkspaces in this PR: #21706

jetlej · 2021-04-29T19:58:00Z

@lacymorrow I still see it in the docs. What would that accomplish anyways?

kylefoo · 2021-10-20T12:52:41Z

it is brought back again, see: #24956

keyurchitroda · 2022-04-07T07:16:32Z

I'm using screenWindow.setVisibleOnAllWorkspaces(true, {visibleOnFullScreen: true}); for window visible on full screen. it's working fine. but app is invisible in macOS dock . If i remove {visibleOnFullScreen: true} then app is visible in macOS dock. but window invisible on full screen. please share me solution if anyone have idea about that. i'm using electron version 11.5.0.

lacymorrow · 2022-04-07T16:58:02Z

This is an OLD bug with Electron, I have this piece of code in my app:

	// Enables staying on fullscreen apps for macos https://github.com/electron/electron/pull/11599
	app.dock.hide()

	// VisibleOnFullscreen removed in https://github.com/electron/electron/pull/21706, still does things for old versions
	win.setVisibleOnAllWorkspaces( true, { visibleOnFullScreen: true } )

	// If we wanted a dock, we can use it now: https://github.com/electron/electron/pull/11599
	app.dock.show()

I believe hiding dock before setVisibleOnAllWorkspaces then showing dock is the workaround.

keyurchitroda · 2022-04-08T04:42:33Z

I was trying this solution,
but if i implement app.dock.show() ,
this win.setVisibleOnAllWorkspaces( true, { visibleOnFullScreen: true } ) functionality is not working , means window is invisible on full screen.

lacymorrow · 2022-04-08T06:33:36Z

There is no way to make an electron window visible above all fullscreen window.

Believe me, I've tried. The best you'll get is

// Values include normal, floating, torn-off-menu, modal-panel, main-menu, status, pop-up-menu, screen-saver
targetWindow.setAlwaysOnTop( true, 'screen-saver' )

If you ever figure it out, please let me know.
lacymorrow/crossover#64

kyle-go · 2022-05-17T12:34:47Z

@lacymorrow
Finally, I found a way to make an electron window visible above all fullscreen window.

const options = {
    width: 240,
    height: 80,
    show: false,  //  !!!!!!!!!!!!!!!!! IMPORTANT, MUST SET HIDE BEFORE call setVisibleOnAllWorkspaces
    webPreferences: {
      nodeIntegration: false,
      nodeIntegrationInWorker: false,
      contextIsolation: false,
      preload: path.join(__dirname, 'preload.js'),
      nativeWindowOpen: true,
      enableRemoteModule: true,
    },
    resizable: false,
    minimizable: false,
    maximizable: false,
    acceptFirstMouse: true,
    movable: true,
    alwaysOnTop: true,
    fullscreenable: false,
    frame: false,
  };
  floatingBarWindow = new BrowserWindow(options);
  floatingBarWindow.loadURL(
      prepareURL([__dirname, 'index.html'], { theme })
  );

  floatingBarWindow.setVisibleOnAllWorkspaces(true,{visibleOnFullScreen:true});

  floatingBarWindow.on('closed', () => {
    floatingBarWindow = null;
  });

  floatingBarWindow.on('ready-to-show', ()=>{
    floatingBarWindow.show();
    app.dock.show(); // SHOW IT!, because setVisibleOnAllWorkspaces will cause app icon dismiss
  })

Last update(2022-06-07):
Sorry, the code above is only work for special macOS version. And the 'app.dock.show()' will take some other problem.
Yes, I think lacymorrow is right. The api setVisibleOnAllWorkspaces not work properly.

lacymorrow · 2022-05-17T21:09:16Z

@kyle-go Do you have an example repo to test/reproduce with?

shivam-bit · 2022-05-24T18:40:36Z

@kyle-go any update on this?

github-actions · 2022-10-06T02:24:13Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

kyle-go · 2022-10-06T19:01:48Z

bump

lacymorrow · 2022-10-13T02:33:34Z

bump

killaragorn · 2022-10-17T09:16:40Z

bump

jordancde · 2022-11-30T21:50:28Z

bump

johnnyopao · 2023-02-24T20:22:18Z

Ran into this and found a configuration that seems to work.

The key seems to be not setting fullscreenable when you init the window and instead do it after configuring setVisibleOnAllWorkspaces + visibleOnFullScreen

  window = new BrowserWindow({
    // DO NOT set fullscreenable here
    // fullscreenable: false,
  });

  window.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

  // NOTE: Make sure this is called after setVisibleOnAllWorkspaces + visibleOnFullScreen
  // otherwise it will not actually show over fullscreen windows
  window.setFullScreenable(false);

not sure if everyone in this thread was using fullscreenable, but if you are and running into this issue try the above!

extrastu · 2023-04-13T08:22:19Z

Ran into this and found a configuration that seems to work.

The key seems to be not setting fullscreenable when you init the window and instead do it after configuring setVisibleOnAllWorkspaces + visibleOnFullScreen
  window = new BrowserWindow({
    // DO NOT set fullscreenable here
    // fullscreenable: false,
  });

  window.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

  // NOTE: Make sure this is called after setVisibleOnAllWorkspaces + visibleOnFullScreen
  // otherwise it will not actually show over fullscreen windows
  window.setFullScreenable(false);
not sure if everyone in this thread was using fullscreenable, but if you are and running into this issue try the above!

This worked for me, thanks

10n37 · 2023-05-19T00:46:26Z

Ran into this and found a configuration that seems to work.

The key seems to be not setting fullscreenable when you init the window and instead do it after configuring setVisibleOnAllWorkspaces + visibleOnFullScreen
  window = new BrowserWindow({
    // DO NOT set fullscreenable here
    // fullscreenable: false,
  });

  window.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

  // NOTE: Make sure this is called after setVisibleOnAllWorkspaces + visibleOnFullScreen
  // otherwise it will not actually show over fullscreen windows
  window.setFullScreenable(false);
not sure if everyone in this thread was using fullscreenable, but if you are and running into this issue try the above!

Not working for me :(

10n37 · 2023-05-31T22:25:20Z

Found the solution. Just set skipTransformProcessType: true in options:

window.setVisibleOnAllWorkspaces(true, {
    visibleOnFullScreen: true,
    skipTransformProcessType: true,
})

lacymorrow · 2023-06-02T10:54:53Z

doesn't work in windows, Electron 9-11

10n37 · 2023-06-05T14:37:02Z

doesn't work in windows, Electron 9-11

but this issue about macOS dock problem.

lacymorrow · 2023-06-05T17:03:42Z

Does this not work for you?
#26350 (comment)

I'm running electron 11 I believe

10n37 · 2023-06-06T00:11:15Z

Does this not work for you? #26350 (comment)

I'm running electron 11 I believe

Works, but it's not a 100% solution. I found some cases where dock can completely disappear.
The solution i found (i'm using electron 22) works fine now

lacymorrow · 2023-06-06T10:47:45Z

I have been sticking with Electron 11 because of this exact issue, looks like I have some testing to do,

10n37 · 2023-06-07T03:02:24Z

Found the solution. Just set skipTransformProcessType: true in options:
window.setVisibleOnAllWorkspaces(true, {
    visibleOnFullScreen: true,
    skipTransformProcessType: true,
})

Nevermind. skipTransformProcessType disables visibleOnFullScreen option
but workspaces still works fine

10n37 · 2023-06-12T22:44:34Z

Found the solution. Just set skipTransformProcessType: true in options:
window.setVisibleOnAllWorkspaces(true, {
    visibleOnFullScreen: true,
    skipTransformProcessType: true,
})
Nevermind. skipTransformProcessType disables visibleOnFullScreen option but workspaces still works fine

Found another trick. This problem solved by combining dock methods and BrowserWindow.setVisibleOnAllWorkspaces

app.dock.hide()

window.setVisibleOnAllWorkspaces(true, {
  visibleOnFullScreen: true,
  skipTransformProcessType: true,
})

await app.dock.show()

10n37 · 2023-06-17T21:57:40Z

Finally able to figure it out.

BrowserWindow settings

const windowSettings = { type: 'panel' }

Method calls while creating window

window.setVisibleOnAllWorkspaces(true, {
  visibleOnFullScreen: true,
  skipTransformProcessType: true,
})

And now it's working perfectly on all workspaces and full-screen mode, without causing dock issue

electron: 22.0.0
macOS: 13.4

UPD: No need to call setVisibleOnAllWorkspaces, just set type: 'panel' in your window settings

const window = new BrowserWindow({type: 'panel'})

electron-issue-triage · 2023-09-16T01:47:41Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

ajay-pipaliya-simform · 2023-12-19T09:28:37Z

Finally able to figure it out.

BrowserWindow settings
const windowSettings = { type: 'panel' }
Method calls while creating window
window.setVisibleOnAllWorkspaces(true, {
  visibleOnFullScreen: true,
  skipTransformProcessType: true,
})
And now it's working perfectly on all workspaces and full-screen mode, without causing dock issue

electron: 22.0.0 macOS: 13.4

I try this, but not working

10n37 · 2023-12-19T09:45:06Z

I try this, but not working

Did you don't forget to set type: 'panel' in BrowserWindow settings?

I created a demo-project by using electron-react-boilerplate, you can try it:
https://github.com/RewriteH/electron-workspaces-visible

ajay-pipaliya-simform · 2023-12-19T11:33:40Z

I try this, but not working

Did you don't forget to set type: 'panel' in BrowserWindow settings?

I created a demo-project by using electron-react-boilerplate, you can try it: https://github.com/RewriteH/electron-workspaces-visible

I added type 'panel' but not working, Here I mentioned my code below. Please let me know if there's an error.

win = new BrowserWindow({
x: width - 384,
y: height - 696,
width: 900,
height: 696,
frame: false,
transparent: false,
resizable: false,
type: 'panel',
skipTaskbar: process.platform === 'win32' ? true : false,
visualEffectState: 'active',
tabbingIdentifier: 'OnTime',
icon: process.platform === 'win32' ?
nativeImage.createFromPath(path.join(__dirname, 'icons', 'winx256.ico')) :
nativeImage.createFromPath(path.join(__dirname, 'icons', 'winx128.png')),
webPreferences: {
devTools: true,
nodeIntegration: true,
allowRunningInsecureContent: (serve) ? true : false,
contextIsolation: false,
},
});

win.setAlwaysOnTop(true, 'pop-up-menu');
win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

10n37 · 2023-12-19T12:06:36Z

I try this, but not working
win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

skipTransformProcessType must also be set to true:

window.setVisibleOnAllWorkspaces(true, {
 visibleOnFullScreen: true,
 skipTransformProcessType: true,
})

Checkout this demo if it's not working properly maybe it depends on OS or Electron version

ajay-pipaliya-simform · 2023-12-19T12:13:36Z

I try this, but not working
win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

skipTransformProcessType must also be set to true:
window.setVisibleOnAllWorkspaces(true, {
 visibleOnFullScreen: true,
 skipTransformProcessType: true,
})
Checkout this demo if it's not working properly maybe it depends on OS or Electron version

your demo is working fine. but not working in my app

10n37 · 2024-02-14T03:40:43Z

just set type: 'panel' in your window settings

Just set type: 'panel' in your window settings

const window = new BrowserWindow({type: 'panel'})

lacymorrow · 2024-02-16T17:51:57Z

Caution that type: panel is only for OSX.

From the docs:

The possible values and behaviors of the type option are platform dependent. Possible values are:

On Linux, possible types are desktop, dock, toolbar, splash, notification.
The desktop type places the window at the desktop background window level (kCGDesktopWindowLevel - 1). However, note that a desktop window will not receive focus, keyboard, or mouse events. You can still use globalShortcut to receive input sparingly.
The dock type creates a dock-like window behavior.
The toolbar type creates a window with a toolbar appearance.
The splash type behaves in a specific way. It is not draggable, even if the CSS styling of the window's body contains -webkit-app-region: drag. This type is commonly used for splash screens.
The notification type creates a window that behaves like a system notification.
On macOS, possible types are desktop, textured, panel.
The textured type adds metal gradient appearance (NSWindowStyleMaskTexturedBackground).
The desktop type places the window at the desktop background window level (kCGDesktopWindowLevel - 1). Note that desktop window will not receive focus, keyboard or mouse events, but you can use globalShortcut to receive input sparingly.
The panel type enables the window to float on top of full-screened apps by adding the NSWindowStyleMaskNonactivatingPanel style mask,normally reserved for NSPanel, at runtime. Also, the window will appear on all spaces (desktops).
On Windows, possible type is toolbar.

yuvalkarmi · 2024-03-13T13:10:11Z

I try this, but not working
win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true });

skipTransformProcessType must also be set to true:
window.setVisibleOnAllWorkspaces(true, {
 visibleOnFullScreen: true,
 skipTransformProcessType: true,
})
Checkout this demo if it's not working properly maybe it depends on OS or Electron version

I can confirm this works as long as you set type to panel in the BrowserWindow settings (I'm running Electron 28.1.3). Thanks VERY much @10n37 - you just saved me lots of time and headache <3

haisamMH · 2024-03-27T17:19:59Z

This worked for me!

myWindow.setAlwaysOnTop(true, "floating");
myWindow.setVisibleOnAllWorkspaces(true, {visibleOnFullScreen: true});
myWindow.setFullScreenable(false);

jkleinsc added the 10-x-y label Nov 5, 2020

mitchchn mentioned this issue Oct 21, 2021

[Feature Request]: Create panel windows (NSPanel) on macOS #31538

Closed

3 tasks

Deuscx mentioned this issue Apr 25, 2022

[Bug]: .setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) Then app.dock.show #33912

Closed

3 tasks

kyle-go mentioned this issue May 17, 2022

CrossOver doesn't work in Fullscreen mode lacymorrow/crossover#64

Open

github-actions bot added the stale label Oct 6, 2022

github-actions bot removed the stale label Oct 7, 2022

lacymorrow added a commit to lacymorrow/crossover that referenced this issue Jul 4, 2023

Fix full-screen mac: electron/electron#26350

1abefef

electron-issue-triage bot added the stale label Sep 16, 2023

electron-issue-triage bot removed the stale label Sep 26, 2023

setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) api cause app dismiss in macOS dock #26350

setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) api cause app dismiss in macOS dock #26350

Comments

fanlion commented Nov 5, 2020 • edited

Preflight Checklist

Issue Details

Expected Behavior

Actual Behavior

To Reproduce

Screenshots

Additional Information

asc0910 commented Nov 6, 2020 • edited

oltreseba commented Nov 25, 2020 • edited

yarinsa commented Jan 19, 2021

oltreseba commented Jan 19, 2021

lacymorrow commented Jan 29, 2021

jetlej commented Apr 29, 2021

kylefoo commented Oct 20, 2021

keyurchitroda commented Apr 7, 2022

lacymorrow commented Apr 7, 2022

keyurchitroda commented Apr 8, 2022 • edited

lacymorrow commented Apr 8, 2022 • edited

kyle-go commented May 17, 2022 • edited

lacymorrow commented May 17, 2022

shivam-bit commented May 24, 2022

github-actions bot commented Oct 6, 2022

kyle-go commented Oct 6, 2022

lacymorrow commented Oct 13, 2022

killaragorn commented Oct 17, 2022

jordancde commented Nov 30, 2022

johnnyopao commented Feb 24, 2023

extrastu commented Apr 13, 2023

10n37 commented May 19, 2023 • edited

10n37 commented May 31, 2023

lacymorrow commented Jun 2, 2023 • edited

10n37 commented Jun 5, 2023

lacymorrow commented Jun 5, 2023

10n37 commented Jun 6, 2023

lacymorrow commented Jun 6, 2023

10n37 commented Jun 7, 2023 • edited

10n37 commented Jun 12, 2023 • edited

10n37 commented Jun 17, 2023 • edited

electron-issue-triage bot commented Sep 16, 2023

ajay-pipaliya-simform commented Dec 19, 2023

10n37 commented Dec 19, 2023

ajay-pipaliya-simform commented Dec 19, 2023 • edited

10n37 commented Dec 19, 2023

ajay-pipaliya-simform commented Dec 19, 2023

10n37 commented Feb 14, 2024

lacymorrow commented Feb 16, 2024

yuvalkarmi commented Mar 13, 2024 • edited

haisamMH commented Mar 27, 2024

fanlion commented Nov 5, 2020 •

edited

asc0910 commented Nov 6, 2020 •

edited

oltreseba commented Nov 25, 2020 •

edited

keyurchitroda commented Apr 8, 2022 •

edited

lacymorrow commented Apr 8, 2022 •

edited

kyle-go commented May 17, 2022 •

edited

10n37 commented May 19, 2023 •

edited

lacymorrow commented Jun 2, 2023 •

edited

10n37 commented Jun 7, 2023 •

edited

10n37 commented Jun 12, 2023 •

edited

10n37 commented Jun 17, 2023 •

edited

ajay-pipaliya-simform commented Dec 19, 2023 •

edited

yuvalkarmi commented Mar 13, 2024 •

edited