Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<webview webpreferences="contextIsolation=true"> incorrectly warns “The default of contextIsolation is deprecated” #26785

Closed
3 tasks done
andersk opened this issue Dec 2, 2020 · 1 comment
Closed
3 tasks done

<webview webpreferences="contextIsolation=true"> incorrectly warns “The default of contextIsolation is deprecated” #26785

andersk opened this issue Dec 2, 2020 · 1 comment
Assignees
@MarshallOfSound
Labels
11-x-y 12-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@andersk
Copy link
Contributor

andersk commented Dec 2, 2020 •
edited
Loading

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.3
    • 11.3.0
  • Operating System:
    • NixOS 21.03 x86_64
  • Last Known Working Electron version:
    • 10.1.6

Expected Behavior

<webview webpreferences="contextIsolation=true"> should not warn that the contextIsolation default is deprecated, since I’m not relying on the default (as verified by the will-attach-webview event).

Actual Behavior

(node:30472) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron. See https://github.com/electron/electron/issues/23506 for more information

To Reproduce

Electron Fiddle: https://gist.github.com/f801279c49c96bed5636fa9196350d64

Additional Information

General issue for contextIsolation default deprecation: #23506.
@ckerr ckerr added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature labels Dec 2, 2020
@Jelmerro Jelmerro mentioned this issue Dec 27, 2020
Closed
@MarshallOfSound
Copy link
Member

This was fixed at one point recently, I just can't find the PR, tested on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
11-x-y 12-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andersk @ckerr @VerteDinde @MarshallOfSound