fix: emit window-all-closed after closing the window #28867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Apr 28, 2021
codebytere
approved these changes
Apr 28, 2021
|
@codebytere 10-x-y is security fixes only, which this is not, so I've removed the target for that backport. |
|
Release Notes Persisted
|
This was referenced Apr 28, 2021
|
I have automatically backported this PR to "11-x-y", please check out #28912 |
|
I have automatically backported this PR to "12-x-y", please check out #28913 |
|
I have automatically backported this PR to "13-x-y", please check out #28914 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #28774. This moves the trigger for emitting the window-all-closed event until after the BrowserWindow has been marked destroyed.
Checklist
npm testpassesRelease Notes
Notes: Fixed the window-all-closed event being emitted while the last BrowserWindow was still in the process of being closed.