-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit window-all-closed after closing the window #28867
Conversation
@codebytere 10-x-y is security fixes only, which this is not, so I've removed the target for that backport. |
Release Notes Persisted
|
I have automatically backported this PR to "11-x-y", please check out #28912 |
I have automatically backported this PR to "12-x-y", please check out #28913 |
I have automatically backported this PR to "13-x-y", please check out #28914 |
Description of Change
Fixes #28774. This moves the trigger for emitting the window-all-closed event until after the BrowserWindow has been marked destroyed.
Checklist
npm test
passesRelease Notes
Notes: Fixed the window-all-closed event being emitted while the last BrowserWindow was still in the process of being closed.