Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: Provide full and correct version in `process.version` #11103
I agree with the assessment of the problems and the goals of this patch, but have a couple of questions --
The semver spec is pretty clear this part of the name is called the 'pre-release version', perhaps we should reflect that here by using
Since this will be commented out for non-prerelease releases, we ought to have an #ifndef fallback just as we do with
Related but perhaps out-of-scope for this patch, I'm not sure what role
ATOM_TAGplays in this, it doesn't seem to be related to anything in semver. Is this a leftover from the old versioning scheme? If so, can we remove it safely?
Also related but perhaps out-of-scope for this patch, it looks like non-releases would have a name something like
1.8.2-beta1-prewhich seems nonsensical. Does
-prehave some magic meaning that we're relying on in scripts somewhere?
As for dealing with downstream fallout, I believe we can rest easy - this change would only affect beta versions, while production versions will continue to report a "simple" version.