[Bug]: Print fails with message 'Print job failed' if the user cancels the saving to PDF

[Hedwig188]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

21.1.0

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

Unknown

Expected Behavior

If the user cancels the printing, treat it as success or at least log the cancel message on both local and remote printers so applications can catch that and suppress the error message accordingly.

Actual Behavior

Inconsistent behavior when printing to local and remote printers (as least for PDF printer, haven't tested out on any physical printers). The print job returns failure message "Print job failed" from local printer and "success" from the remote printer which caused some confusion to the end user.

Testcase Gist URL

https://gist.github.com/d43cee547b874cbecd32a17bda9ad904

Additional Information

Run the above code and select "Microsoft Print to PDF" local printer on the window's default print dialog. Once the file explore opens, cancel the saving to the PDF file. See the console outputs "Print job failed". However, if you select any PDF printer from the remote session and cancel the saving, the print job returns success instead.

[Hedwig188]

Likely new with this PR.

[codebytere]

I'm unable to reproduce this using the steps above - when selecting "Microsoft Print to PDF" local printer on the window's default print dialog and then cancelling i see "Print job canceled"

[Hedwig188]

I'm unable to reproduce this using the steps above - when selecting "Microsoft Print to PDF" local printer on the window's default print dialog and then cancelling i see "Print job canceled"

I reproduced this with Electron v21.1.0 on Windows 10 Enterprise with OS build 19044.2130. Not sure if that makes any difference.

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Hedwig188]

Still reproducible in v22.

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Hedwig188]

bumpOn Jul 10, 2023, at 21:04, github-actions[bot] ***@***.***> wrote: This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[dominic-simplan]

Same (?) issue here.
Cancelling the print system dialog rejects with message "Print job canceled" (correct)
Selecting "Print" for the "Microsoft Print to PDF" printer in the print system dialog and then cancelling the Save dialog for the PDF rejects with message "Print job failed". (unexpected?)

Using Electron 20.1.4 on Windows 11.

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Hedwig188]

bump

…

On Nov 23, 2023, at 7:49 PM, electron-issue-triage[bot] ***@***.***> wrote: This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron <https://www.electronjs.org/releases/stable> or in the beta <https://www.electronjs.org/releases/beta>—please include it with your comment! — Reply to this email directly, view it on GitHub <#36084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABA53NLLKMFZC5B47KCH44TYF74K5AVCNFSM6AAAAAARJQ2N6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGA2TKOBUGQ>. You are receiving this because you authored the thread.

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Hedwig188]

bumpOn Feb 23, 2024, at 19:46, electron-issue-triage[bot] ***@***.***> wrote: This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[pushkin-]

repros with v30.0.8