-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: formally deprecate crashed
and renderer-process-crashed
events
#40089
Conversation
c5ee6c7
to
6cbbf84
Compare
6cbbf84
to
62c436f
Compare
🪦 Deprecation Checklist🔥 New deprecations in this PR
@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crashed
and render-process-gone
events are on WebContents
, not BrowserWindow
.
Title of this PR should refer to |
62c436f
to
6582736
Compare
@dsanders11 oops, I don't know how I missed that. Fixed now. |
crashed
and render-process-gone
eventscrashed
and renderer-process-crashed
events
6582736
to
0d3364a
Compare
@dsanders11 Sadly the tests cannot be added easily as the tests don't share the instance of |
@dsanders11 We need to do this #40124 |
0d3364a
to
2992c94
Compare
2992c94
to
7e34413
Compare
@dsanders11 the warnings are in main now |
@miniak, I'm not sure if #40124 was necessary here. I added |
@dsanders11 I completely missed that somehow. Fixing in #40146 |
Release Notes Persisted
|
Description of Change
Deprecated since #23096, #24410, #39494
Warnings fixed in #40090
Checklist
Release Notes
Notes: The
renderer-process-crashed
event onapp
andcrashed
event onWebContents
and<webview>
have been deprecated.