build: fix release notes script bug that omitted edited release-clerk comments #40634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comments add a warning when neither notes nor no-notes are found
ckerr
added
component/build
semver/none
target/26-x-y
codebytere
approved these changes
Nov 29, 2023
…e-clerk comments use console.warn() instead of console.log()
|
No Release Notes |
|
I have automatically backported this PR to "26-x-y", please check out #40654 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #40655 |
|
I have automatically backported this PR to "28-x-y", please check out #40656 |
trop
bot
added
in-flight/27-x-y
in-flight/28-x-y
merged/28-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
… comments (electron#40634) * build: fix release notes script bug that omitted edited release-clerk comments add a warning when neither notes nor no-notes are found * fixup! build: fix release notes script bug that omitted edited release-clerk comments use console.warn() instead of console.log()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes the "some PRs are missing from the notes" issue I mentioned to @mlaurencin earlier today. Apparently, edited comments on GitHub can be stored with
\r\n\r\nbetween paragraphs instead of\n\n, which broke thePERSIST_LEADcheck in the notes generator. Happily, the fix is easy: remove\n\nfrom the test.I've also added a warning if we ever reach a PR that doesn't have a note and doesn't have a no-note, so any future issues like this one won't fail silently.
CC @mlaurencin @VerteDinde
Checklist
npm testpassesRelease Notes
Notes: none