Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non random ID for trayIcon #5969

Closed
andia89 opened this issue Jun 9, 2016 · 4 comments
Closed

Use non random ID for trayIcon #5969

andia89 opened this issue Jun 9, 2016 · 4 comments

Comments

@andia89
Copy link

andia89 commented Jun 9, 2016

  • Electron version: All
  • Operating system: Ubuntu 16.04

Looking at the source code,

base::GenerateGUID(), image.AsImageSkia(), empty));
it seems that for the AppIndicator tray icon uses a randomly generated ID for the tray icon. This number changes everytime the app starts. This creates problems, because the ID is used in Ubuntu for changing order of tray icons, which is impossible if the ID changes everytime the app starts.

Is there a reason why a Random number is used as AppIndictor ID? Is it possible to change that to let's say the app name, or at least to something that is not random?

@zcbenz
Copy link
Member

zcbenz commented Jun 10, 2016

I think we can change the ID to something like app_name_1.

@andia89
Copy link
Author

andia89 commented Jun 10, 2016

Great! Would you accept a PR with a fix?

@zcbenz
Copy link
Member

zcbenz commented Jun 10, 2016

Sure, a PR would be awesome.

andia89 added a commit to andia89/electron that referenced this issue Jun 10, 2016
@andia89
Copy link
Author

andia89 commented Jun 10, 2016

Alright, pushed a fix. seems to be working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants