New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed ID for app indicators #6145

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jun 20, 2016

Close #5969.

@zcbenz zcbenz referenced this pull request Jun 20, 2016

Closed

Fixes #5969 #5988

@zcbenz zcbenz merged commit b87cf37 into master Jun 20, 2016

6 of 8 checks passed

electron-win-x64 Build #611 failed in 6 min 37 sec
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3478003 succeeded in 41s
Details
electron-linux-ia32 Build #3478004 succeeded in 35s
Details
electron-linux-x64 Build #3478005 succeeded in 136s
Details
electron-mas-x64 Build #1615 succeeded in 6 min 44 sec
Details
electron-osx-x64 Build #1620 succeeded in 6 min 11 sec
Details
electron-win-ia32 Build #617 succeeded in 6 min 20 sec
Details

@zcbenz zcbenz deleted the app-indicator-id branch Jun 20, 2016

@wa4557

This comment has been minimized.

wa4557 commented Jun 20, 2016

Thanks! Sorry for not doing this earlier :)

@nornagon nornagon referenced this pull request Nov 2, 2018

Merged

refactor: don't use AppIndicatorIcon directly #15536

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment