Improve cycle detection in IPC arguments #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port over the https://bugs.chromium.org/p/chromium/issues/detail?id=606955 fix from Chromium to Electron's
V8ValueConverterto improve cycle detection in arguments passed over IPC calls.This allows duplicate references in arrays and objects that aren't true cycles to be sent successfully over IPC that were previous
null-ed out.Chromium fix: https://chromium.googlesource.com/chromium/src/+/275ec3e2a5ce1d16fc9c2a0dab3b58f8a7b9fa38
Closes #3598