Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cast (Chromecast) in Electron #7024

Closed
evancohen opened this issue Aug 29, 2016 · 2 comments
Closed

Google Cast (Chromecast) in Electron #7024

evancohen opened this issue Aug 29, 2016 · 2 comments

Comments

@evancohen
Copy link

Enhancement
Now that Google Cast is built into Chrome and is a part of chromium it would be awesome to have this functionality baked into Electron.

There is already an Electron wrapper for Chromecast (GPMDP/electron-chromecast via @MarshallOfSound in #869), so maybe the best approach would be to integrate that wrapper directly into Electron.

Having Cast functionality out of the box would be useful for a lot of electron apps in the ecosystem today, for example:

Organized links

@evancohen evancohen changed the title Google Cast (Chromecast) in Electron [enhancement] Google Cast (Chromecast) in Electron Aug 29, 2016
@MarshallOfSound
Copy link
Member

Thought I'd chime in here.

First of all the GPMDP/electron-chromecast module is hacky to say the least. It is more of a polyfill than an implementation and it does the bare minimum required to "Just Work"(TM) with basic cast usage.

I would love it if the Google Cast implementation inside Chromium could be ported to Electron. However (and this is related to #5612) there are a number of issues I came across while attempting a port previously.

  1. Google Chrome uses a built in MDNS scanner. The MDNS spec says you must listen for and send requests from port 5353. Most Windows machines default firewall configuration block these requests without adding an exception to the firewall. Adding an exception requires Admin permissions and most Electron applications aren't even installed with Admin permissions (let alone run with them).
  2. Google Chrome has a built in UI for the Chromecast selector. We would have to implement an interface similar to electron-chromecast where it allows clients to implement there on device chooser.
  3. As far as I can tell, running two instances of Google Chrome's MDNS implementation simultaneously doesn't play nicely. So running an Electron application with cast integration enabled and Google Chrome at the same time could cause issues.

Personally I have tried to do this implementation before and failed at these rather significant hurdles (hence the electron-chromecast implementation).

@zcbenz
Copy link
Member

zcbenz commented May 30, 2017

I'm closing this issue and reopening #869 since it is the first issue on chromecast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants